| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM.
@serhiy-storchaka @ronaldoussoren: Do you want to double check this plistlib change?
Sorry, something went wrong.
There was a problem hiding this comment.
Please add a NEWS entry. Note that support of frozendict is half-hearted -- only for serialization. dict_type=frozendict does not work in load(). I am not sure that it is worth to add support for deserialization.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh, can you also add plistlib to https://docs.python.org/dev/whatsnew/3.15.html#whatsnew315-frozendict?
Sorry, something went wrong.
I saw that and hesitated to propose a follow-up change to add frozendict support for deserialization. It should be possible to create a (mutable) dict, populate the dictionary, and then convert the dict to a frozendict. |
Sorry, something went wrong.
This can add an overhead and this would not work in case of cyclic references in binary Plist. Originally, dict_type was only added to support OrderedDict. Now, when dict is ordered, this parameter is mostly useless. If there was other use cases for this feature, we would need also an option to override the list type. So, there is very little value in such feature, and it is very difficult to do without breaking corner cases. But this should be explicitly stated that frozendicts are supported only in one way (like tuple). |
Sorry, something went wrong.
Co-authored-by: Victor Stinner <vstinner@python.org>
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
| Back | FazBrowse Home | New Git URL |
📚 Documentation preview 📚: https://cpython-previews--145590.org.readthedocs.build/