Repository navigation
[3.13] gh-145376: Fix crashes in md5module.c (GH-145422) - #145611
Merged
vstinner merged 3 commits intoMar 6, 2026
Merged
vstinner merged 3 commits into
vstinner merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fix a possible NULL pointer dereference in `md5module.c`. This can only occur in error paths taken when the interpreter fails to allocate memory. (cherry-picked from c1d7768)
vstinner
reviewed
Mar 6, 2026
Comment thread
Modules/md5module.c
Outdated
| Hacl_Hash_MD5_free(ptr->hash_state); | ||
| if (ptr->hash_state != NULL) { | ||
| Hacl_Hash_MD5_free(ptr->hash_state); | ||
| ptr->hash_state == NULL; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This line should be: ptr->hash_state = NULL;
Sorry, something went wrong.
vstinner
reviewed
Mar 6, 2026
eendebakpt
commented
Mar 6, 2026
Comment thread
Modules/md5module.c
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a possible NULL pointer dereference in md5module.c.
This can only occur in error paths taken when the interpreter fails to allocate memory.
(cherry-picked from c1d7768)