FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-145623: Fix crashes on uninitialized struct.Struct objects by raminfp · Pull Request #145624 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-145623: Fix crashes on uninitialized struct.Struct objects - #145624

Merged
corona10 merged 2 commits into
python:mainfrom
raminfp:fix-gh-145623-struct-uninitialized-crash
Mar 7, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-145623: Fix crashes on uninitialized struct.Struct objects#145624
corona10 merged 2 commits into
python:mainfrom
raminfp:fix-gh-145623-struct-uninitialized-crash

Conversation

raminfp commented Mar 7, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Add ENSURE_STRUCT_IS_READY() checks to Struct.__sizeof__() and Struct.__repr__() to prevent crashes when called on uninitialized Struct objects.

bedevere-app Bot mentioned this pull request Mar 7, 2026
Closed
raminfp added 2 commits March 7, 2026 15:18
gh-145623: Fix crashes on uninitialized struct.Struct objects
2cc2bcc 
Add ENSURE_STRUCT_IS_READY() checks to Struct.__sizeof__() and
Struct.__repr__() to prevent NULL pointer dereference and invalid
memory read when called on a Struct created via __new__() without
__init__().
trigger CI
75e34c8
corona10 added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Mar 7, 2026
corona10 approved these changes Mar 7, 2026
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!

corona10 merged commit 2cf6b2c into python:main Mar 7, 2026
62 checks passed

miss-islington-app Bot commented Mar 7, 2026

Copy link
Copy Markdown

Thanks @raminfp for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Mar 7, 2026

Copy link
Copy Markdown

Sorry, @raminfp and @corona10, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2cf6b2caade94e75f10363df6f432a3e6515be6c 3.14

miss-islington-app Bot commented Mar 7, 2026

Copy link
Copy Markdown

Sorry, @raminfp and @corona10, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2cf6b2caade94e75f10363df6f432a3e6515be6c 3.13

corona10 commented Mar 7, 2026

Copy link
Copy Markdown
Member

@raminfp In my local environment, Python 3.14 and 3.13 have same issue, would you like to create a backport patch for this?

raminfp mentioned this pull request Mar 7, 2026
Merged

bedevere-app Bot commented Mar 7, 2026

Copy link
Copy Markdown

GH-145630 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 7, 2026
raminfp mentioned this pull request Mar 7, 2026
Merged

bedevere-app Bot commented Mar 7, 2026

Copy link
Copy Markdown

GH-145631 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 7, 2026
encukou pushed a commit that referenced this pull request Mar 9, 2026
[3.14] gh-145623: Fix crashes on uninitialized struct.Struct objects (g…
7c624d4 
…h-145624) (GH-145630)
encukou pushed a commit that referenced this pull request Mar 9, 2026
[3.13] gh-145623: Fix crashes on uninitialized struct.Struct objects (g…
b289462 
…h-145624) (GH-145631)
raminfp deleted the fix-gh-145623-struct-uninitialized-crash branch March 12, 2026 03:34
skirpichev mentioned this pull request Mar 18, 2026
Open
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-145623: Fix crashes on uninitialized struct.Struct objects (p…
11286a2 
…ythongh-145624)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skirpichev skirpichev approved these changes
corona10 corona10 approved these changes

Assignees

corona10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL