FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-145681: do not deallocate list buffer in `_PyList_AsTupleAndClear` by KowalskiThomas · Pull Request #145680 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-145681: do not deallocate list buffer in _PyList_AsTupleAndClear - #145680

Merged
encukou merged 3 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-reset-list-allocated-to-0
Mar 12, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-145681: do not deallocate list buffer in _PyList_AsTupleAndClear#145680
encukou merged 3 commits into
python:mainfrom
KowalskiThomas:kowalski/fix-reset-list-allocated-to-0

Conversation

KowalskiThomas commented Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This is a fix for gh-145681.

Note I wanted to open this PR in my fork for the time being (until issue has been reviewed/triaged), but I accidentally opened it in the public CPython directly... Sorry about that.

KowalskiThomas mentioned this pull request Mar 9, 2026
Closed
KowalskiThomas changed the title fix: reset list allocated to 0 gh-145681: reset list allocated to 0 Mar 9, 2026

KowalskiThomas commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

I meant to open this PR in my fork until my issue has been reviewed/triaged and bug has been confirmed or rejected but I forgot to select the target repo for the PR... sorry about this.

sergey-miryanov reviewed Mar 9, 2026
View reviewed changes
Comment thread Objects/listobject.c Outdated
Py_ssize_t size = Py_SIZE(self);
self->ob_item = NULL;
Py_SET_SIZE(self, 0);
self->allocated = 0;

sergey-miryanov Mar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

list_clear_impl has extra code if Py_GIL_DISABLED - should we include it here?

KowalskiThomas Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the comment, there is a discussion on the issue right now but I'll keep that in mind when time comes.

encukou approved these changes Mar 11, 2026
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!
Do you want to take this out of draft?

KowalskiThomas marked this pull request as ready for review March 11, 2026 14:17

KowalskiThomas commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

Do you want to take this out of draft?

Oops, yes!

KowalskiThomas changed the title gh-145681: reset list allocated to 0 gh-145681: do not deallocate list buffer in _PyList_AsTupleAndClear Mar 12, 2026
encukou merged commit 7836ecc into python:main Mar 12, 2026
53 checks passed
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-145681: do not deallocate list buffer in `_PyList_AsTupleAnd…
41772aa 
…Clear` (pythonGH-145680)

Setting the size to 0 turns the list contents into overallocated memory that the deallocator will free.
Ownership is transferred to the new tuple so no refcount adjustment is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sergey-miryanov sergey-miryanov left review comments
encukou encukou approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL