FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-37493: use _PyObject_CallNoArg in more places by jdemeyer · Pull Request #14575 · python/cpython · GitHub

Repository navigation

bpo-37493: use _PyObject_CallNoArg in more places - #14575

Merged
methane merged 1 commit into
python:masterfrom
jdemeyer:call_no_args
Jul 4, 2019
Merged

methane merged 1 commit into
python:masterfrom
jdemeyer:call_no_args

Conversation

jdemeyer commented Jul 3, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

skrah previously requested changes Jul 3, 2019

skrah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm a bit surprised --- we discussed on bpo to use fewer places, but you add more.

So please take out the decimal changes. I'll add new functions as I see fit.

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

jdemeyer commented Jul 3, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor Author

we discussed on bpo to use fewer places, but you add more.

I'm not sure what you mean. The only thing that we discussed (on bpo-37483 which relates to a different PR) is that maybe we should not use private functions in _decimal.c. However, in this case I'm using a documented public function, belonging to the limited API PyObject_CallNoArgs.

So please let me know whether the changes to _decimal.c should be reverted anyway.

skrah commented Jul 3, 2019

Copy link
Copy Markdown
Contributor

The PR title mentions _PyObject_CallNoArg(). I see now that there are other functions in the _decimal.c diff, but again not in speed sensitive locations.

So perhaps there are too many new functions. I'll decide later if to use any of these, so yes, please take them out.

jdemeyer commented Jul 3, 2019

Copy link
Copy Markdown
Contributor Author

not in speed sensitive locations.

Even if it's not speed sensitive, I see no reason to prefer PyObject_CallObject(func, NULL) over PyObject_CallNoArgs(func).

jdemeyer commented Jul 4, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

Copy link
Copy Markdown

Thanks for making the requested changes!

@skrah: please review the changes made to this pull request.

skrah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the changes.

methane merged commit 7f41c8e into python:master Jul 4, 2019
jdemeyer deleted the call_no_args branch July 4, 2019 10:46
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL