| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
I'm a bit surprised --- we discussed on bpo to use fewer places, but you add more.
So please take out the decimal changes. I'll add new functions as I see fit.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. And if you don't make the requested changes, you will be poked with soft cushions! |
Sorry, something went wrong.
I'm not sure what you mean. The only thing that we discussed (on bpo-37483 which relates to a different PR) is that maybe we should not use private functions in _decimal.c. However, in this case I'm using a documented public function, belonging to the limited API PyObject_CallNoArgs. So please let me know whether the changes to _decimal.c should be reverted anyway. |
Sorry, something went wrong.
|
The PR title mentions _PyObject_CallNoArg(). I see now that there are other functions in the _decimal.c diff, but again not in speed sensitive locations. So perhaps there are too many new functions. I'll decide later if to use any of these, so yes, please take them out. |
Sorry, something went wrong.
Even if it's not speed sensitive, I see no reason to prefer PyObject_CallObject(func, NULL) over PyObject_CallNoArgs(func). |
Sorry, something went wrong.
|
I have made the requested changes; please review again |
Sorry, something went wrong.
|
Thanks for making the requested changes! @skrah: please review the changes made to this pull request. |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for the changes.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
CC @vstinner @methane
https://bugs.python.org/issue37493