FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-142518: Add thread safety notes for the buffer protocol by lysnikolaou · Pull Request #145911 · python/cpython · GitHub

/ cpython Public

gh-142518: Add thread safety notes for the buffer protocol - #145911

Merged
lysnikolaou merged 4 commits into
python:mainfrom
lysnikolaou:buffer-protocol-thread-safety
Mar 18, 2026
ConversationCommits (4)ChecksFiles changed
Merged

gh-142518: Add thread safety notes for the buffer protocol#145911
lysnikolaou merged 4 commits into
python:mainfrom
lysnikolaou:buffer-protocol-thread-safety

Conversation

lysnikolaou commented Mar 13, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added docs Documentation in the Doc dir skip news labels Mar 13, 2026
bedevere-app Bot mentioned this pull request Mar 13, 2026
Closed
github-project-automation Bot moved this to Todo in Docs PRs Mar 13, 2026
lysnikolaou mentioned this pull request Mar 13, 2026
Open
50 tasks
kumaraditya303 reviewed Mar 16, 2026
View reviewed changes
Comment thread Doc/c-api/typeobj.rst Outdated

* The export counter decrement in step (1) must be atomic.

* Resource cleanup when the counter reaches zero must be reentrant,

kumaraditya303 Mar 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

not sure why it needs to be re-entrant, can you give an example?

lysnikolaou Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What I meant here is that resource cleanup should only happen once. Or, in general, be handled gracefully. Should I update the wording you think?

kumaraditya303 approved these changes Mar 16, 2026
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One question otherwise LGTM

lysnikolaou added the needs backport to 3.14 bugs and security fixes label Mar 18, 2026
lysnikolaou merged commit 847f83e into python:main Mar 18, 2026
30 checks passed
github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 18, 2026

miss-islington-app Bot commented Mar 18, 2026

Copy link
Copy Markdown

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2026
pythongh-142518: Add thread safety notes for the buffer protocol (pyt…
7718a54 
…honGH-145911)

(cherry picked from commit 847f83e)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>

bedevere-app Bot commented Mar 18, 2026

Copy link
Copy Markdown

GH-146106 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 18, 2026
lysnikolaou added a commit that referenced this pull request Mar 18, 2026
[3.14] gh-142518: Add thread safety notes for the buffer protocol (GH…
f20a637 
…-145911) (#146106)

(cherry picked from commit 847f83e)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
pablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-142518: Add thread safety notes for the buffer protocol (pyt…
6c85db7 
…hon#145911)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes
willingc Awaiting requested review from willingc willingc is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-free-threading

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL