| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
|
Auto-backported test will probably fail CI as the test includes new -X options that older releases don't have. I'll clean that up in the backport PR branches. |
Sorry, something went wrong.
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
…ocesses (pythonGH-146005) Propagate all -X command line options to multiprocessing spawned child Python processes. (cherry picked from commit 1efe441) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
|
Sorry, @gpshead, I could not cleanly backport this to 3.13 due to a conflict. cherry_picker 1efe441de7c448852b9ba51fb0db4d355a7157a8 3.13 |
Sorry, something went wrong.
|
GH-146552 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
…rocesses (GH-146005) (#146552) gh-146004: propagate all -X options to multiprocessing child processes (GH-146005) Propagate all -X command line options to multiprocessing spawned child Python processes. (cherry picked from commit 1efe441) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit 1efe441. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1241/builds/8204 Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\os_helper.py", line 524, in temp_dir
os.mkdir(path)
~~~~~~~~^^^^^^
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'C:\\bbarea\\3.x.itamaro-win64-srv-22-aws.x64.nogil\\build\\build\\test_python_13292æ'
Stack (most recent call last):
File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\runpy.py", line 87, in _run_code
exec(code, run_globals)
File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\libregrtest\worker.py", line 141, in <module>
main()
File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\libregrtest\worker.py", line 136, in main
with os_helper.temp_cwd(work_dir, quiet=True):
File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\contextlib.py", line 141, in __enter__
return next(self.gen)
File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\os_helper.py", line 597, in temp_cwd
with temp_dir(path=name, quiet=quiet) as temp_path:
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Windows PGO Tailcall 3.x (tier-1) has failed when building commit 1efe441. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1870/builds/252 Failed tests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "C:\bbarea\3.x.itamaro-win64-srv-22-aws.tailcall.pgo\build\Lib\test\test_profiling\test_sampling_profiler\test_advanced.py", line 169, in test_native_frames_enabled
self.assertFalse(any(stack.endswith(";<native>") for stack in stacks))
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: True is not false
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.14 (tier-1) has failed when building commit 28d3b9b. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1717/builds/1129 Summary of the results of the build (if available): == Click to see traceback logsremote: Enumerating objects: 11, done.
remote: Counting objects: 10% (1/10)
remote: Counting objects: 20% (2/10)
remote: Counting objects: 30% (3/10)
remote: Counting objects: 40% (4/10)
remote: Counting objects: 50% (5/10)
remote: Counting objects: 60% (6/10)
remote: Counting objects: 70% (7/10)
remote: Counting objects: 80% (8/10)
remote: Counting objects: 90% (9/10)
remote: Counting objects: 100% (10/10)
remote: Counting objects: 100% (10/10), done.
remote: Total 11 (delta 9), reused 9 (delta 9), pack-reused 1 (from 1)
From https://github.com/python/cpython
* branch 3.14 -> FETCH_HEAD
Note: switching to '28d3b9bc56df6c2da3e898a0b7a066df5761b04d'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 28d3b9bc56d [3.14] gh-146004: propagate all -X options to multiprocessing child processes (GH-146005) (#146552)
Switched to and reset branch '3.14'
Could Not Find C:\bbarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find C:\bbarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\PCbuild\python*.zip
Could Not Find C:\bbarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\PCbuild\python*.zip |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Windows10 3.x (tier-1) has failed when building commit 1efe441. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/146/builds/13440 Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 524, in temp_dir
os.mkdir(path)
~~~~~~~~^^^^^^
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_1152æ'
Stack (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 87, in _run_code
exec(code, run_globals)
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\worker.py", line 141, in <module>
main()
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\worker.py", line 136, in main
with os_helper.temp_cwd(work_dir, quiet=True):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 141, in __enter__
return next(self.gen)
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 597, in temp_cwd
with temp_dir(path=name, quiet=quiet) as temp_path:
Traceback (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 524, in temp_dir
os.mkdir(path)
~~~~~~~~^^^^^^
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'D:\\buildarea\\3.x.bolen-windows10\\build\\build\\test_python_11832æ'
Stack (most recent call last):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "D:\buildarea\3.x.bolen-windows10\build\Lib\runpy.py", line 87, in _run_code
exec(code, run_globals)
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\worker.py", line 141, in <module>
main()
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\libregrtest\worker.py", line 136, in main
with os_helper.temp_cwd(work_dir, quiet=True):
File "D:\buildarea\3.x.bolen-windows10\build\Lib\contextlib.py", line 141, in __enter__
return next(self.gen)
File "D:\buildarea\3.x.bolen-windows10\build\Lib\test\support\os_helper.py", line 597, in temp_cwd
with temp_dir(path=name, quiet=quiet) as temp_path:
|
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Windows11 Bigmem 3.x (tier-1) has failed when building commit 1efe441. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1079/builds/8289 Summary of the results of the build (if available): == Click to see traceback logsremote: Enumerating objects: 11, done.
remote: Counting objects: 10% (1/10)
remote: Counting objects: 20% (2/10)
remote: Counting objects: 30% (3/10)
remote: Counting objects: 40% (4/10)
remote: Counting objects: 50% (5/10)
remote: Counting objects: 60% (6/10)
remote: Counting objects: 70% (7/10)
remote: Counting objects: 80% (8/10)
remote: Counting objects: 90% (9/10)
remote: Counting objects: 100% (10/10)
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 25% (1/4)
remote: Compressing objects: 50% (2/4)
remote: Compressing objects: 75% (3/4)
remote: Compressing objects: 100% (4/4)
remote: Compressing objects: 100% (4/4), done.
remote: Total 11 (delta 6), reused 6 (delta 6), pack-reused 1 (from 1)
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '1efe441de7c448852b9ba51fb0db4d355a7157a8'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 1efe441de7c gh-146004: propagate all -X options to multiprocessing child processes (GH-146005)
Switched to and reset branch 'main'
Could Not Find R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find R:\buildarea\3.x.ambv-bb-win11.bigmem\build\PCbuild\python*.zip
Could Not Find R:\buildarea\3.x.ambv-bb-win11.bigmem\build\PCbuild\python*.zip |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Windows10 3.14 (tier-1) has failed when building commit 28d3b9b. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1711/builds/890 Summary of the results of the build (if available): == Click to see traceback logsremote: Enumerating objects: 11, done.
remote: Counting objects: 14% (1/7)
remote: Counting objects: 28% (2/7)
remote: Counting objects: 42% (3/7)
remote: Counting objects: 57% (4/7)
remote: Counting objects: 71% (5/7)
remote: Counting objects: 85% (6/7)
remote: Counting objects: 100% (7/7)
remote: Counting objects: 100% (7/7), done.
remote: Total 11 (delta 7), reused 7 (delta 7), pack-reused 4 (from 2)
From https://github.com/python/cpython
* branch 3.14 -> FETCH_HEAD
Note: switching to '28d3b9bc56df6c2da3e898a0b7a066df5761b04d'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 28d3b9bc56d [3.14] gh-146004: propagate all -X options to multiprocessing child processes (GH-146005) (#146552)
Switched to and reset branch '3.14'
Could Not Find D:\buildarea\3.14.bolen-windows10\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find D:\buildarea\3.14.bolen-windows10\build\PCbuild\python*.zip
Could Not Find D:\buildarea\3.14.bolen-windows10\build\PCbuild\python*.zip |
Sorry, something went wrong.
|
test_support fails on Windows buildbots: Warning -- files was modified by test_support Warning -- Before: [] Warning -- After: ['tmp/'] I don't see the relationship with the change. |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Windows11 Non-Debug 3.14 (tier-1) has failed when building commit 28d3b9b. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1684/builds/511 Summary of the results of the build (if available): == Click to see traceback logsremote: Enumerating objects: 16, done.
remote: Counting objects: 12% (1/8)
remote: Counting objects: 25% (2/8)
remote: Counting objects: 37% (3/8)
remote: Counting objects: 50% (4/8)
remote: Counting objects: 62% (5/8)
remote: Counting objects: 75% (6/8)
remote: Counting objects: 87% (7/8)
remote: Counting objects: 100% (8/8)
remote: Counting objects: 100% (8/8), done.
remote: Total 16 (delta 7), reused 7 (delta 7), pack-reused 8 (from 3)
From https://github.com/python/cpython
* branch 3.14 -> FETCH_HEAD
Note: switching to '28d3b9bc56df6c2da3e898a0b7a066df5761b04d'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 28d3b9bc56d [3.14] gh-146004: propagate all -X options to multiprocessing child processes (GH-146005) (#146552)
Switched to and reset branch '3.14'
Could Not Find b:\uildarea\3.14.ware-win11.nondebug\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find b:\uildarea\3.14.ware-win11.nondebug\build\PCbuild\python*.zip
Could Not Find b:\uildarea\3.14.ware-win11.nondebug\build\PCbuild\python*.zip |
Sorry, something went wrong.
|
I think the problem is ['-X', 'pycache_prefix=/tmp/pycache']. We should use another temporary folder here. (The problem is likely because we are using / on Windows platforms) |
Sorry, something went wrong.
|
I suggest just using test.support's temporary directory instead (a fresh one). It doesn't matter that we use a real OS-tempdir |
Sorry, something went wrong.
|
I won't be able to get to this today. That makes sense as a fix. |
Sorry, something went wrong.
|
No worries! Chris handled it already: #146580 |
Sorry, something went wrong.
| ['-X', 'dev'], | ||
| ['-Wignore', '-X', 'dev'], | ||
| ['-X', 'cpu_count=4'], | ||
| ['-X', 'disable-remote-debug'], |
There was a problem hiding this comment.
This is documented as
-X disable_remote_debug
with underscores.
Furthermore, -X presite=package.module, -X gil=0,1 and some more aren't listed here.
Not a big issue IMHO, since this just tests that whatever we pass in is returned from args_from_interpreter_flags?
Sorry, something went wrong.
There was a problem hiding this comment.
So an alternative fix for #146580 would be to just remove ['-X', 'pycache_prefix=/tmp/pycache'],?
Sorry, didn't realize earlier, just stumbled over it now ...
Sorry, something went wrong.
…ocesses (pythonGH-146005) Propagate all -X command line options to multiprocessing spawned child Python processes.
…ocesses (pythonGH-146005) Propagate all -X command line options to multiprocessing spawned child Python processes.
|
Please don't forget about backports. |
Sorry, something went wrong.
|
GH-155938 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…ocesses (pythonGH-146005) Propagate all -X command line options to multiprocessing spawned child Python processes. (cherry picked from commit 1efe441) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
See the issue for details. Our list of -X options to opt-in was overlooking a lot. CI and buildbot tests on these may prove interesting.