Repository navigation
gh-145989: Fix double Py_DECREF in pyexpat ExternalEntityParserCreate - #146017
Closed
0xCyberstan wants to merge 1 commit into
Closed
0xCyberstan wants to merge 1 commit into
0xCyberstan wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Remove redundant Py_DECREF(self) from three error paths in ExternalEntityParserCreate_impl(). The dealloc of new_parser already decrements the parent reference via Py_CLEAR(self->parent). Use Py_NewRef() for the parent assignment for clarity.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
There is already a PR and issue for that: #144984 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant Py_DECREF(self) from three error paths in ExternalEntityParserCreate_impl(). The dealloc of new_parser already decrements the parent reference via Py_CLEAR(self->parent).
Use Py_NewRef() for the parent assignment for clarity.