gh-142927: Show module names instead of file paths in flamegraph - #146040
gh-142927: Show module names instead of file paths in flamegraph#146040pablogsal merged 8 commits into
Conversation
Sorry, something went wrong.
|
As I am on mobile it is hard to review but is it possible to have an option to keep showing full paths? this may help if we want to open the file in an IDE. Or does this change only affect the flamegraph output? Alternative: show the full path of the selected cell as a footer |
Sorry, something went wrong.
@picnixz That’s a great idea. I’ve added a toggle that lets users switch between full paths and module names. Toggling it updates both the flamegraph frames and the hover tooltips. This change only affects the flamegraph output. Let me know what you think of the toggle. |
Sorry, something went wrong.
|
Toggling was one solution I had in mind so it is fine! showing full path without toggling as a small footer with a "copy path" if you were to double click the footer would also be an alternative/follow-up improvement. Otherwise just toggling is great! thanks! |
Sorry, something went wrong.
pablogsal
left a comment
There was a problem hiding this comment.
some comments
Sorry, something went wrong.
| if (useModuleNames) { | ||
| return moduleName || filename; | ||
| } | ||
| return filename ? filename.split('/').pop() : filename; |
There was a problem hiding this comment.
The toggle is labeled "Full Paths" but this returns filename.split("/").pop() which is the basename. Also the tooltip builds displayName differently (using the full filename), so different parts of the UI disagree on what to show.
Sorry, something went wrong.
There was a problem hiding this comment.
What do you think about “File Paths” and “Module Names”? I updated displayName to return the filename and kept the tooltip showing the full path, does that sound okay?
Sorry, something went wrong.
Move module name extraction logic from heatmap_collector to shared module_utils to enable flamegraph to display module names instead of full file paths.
Display module names instead of full file paths (/home/user/project/pkg/mod.py → pkg.mod) in flamegraph for readability.
Users can now switch between module names and file paths using the toggle in the View Mode sidebar. Module names are concise, while file paths help locate the exact source file, both are useful depending on the debugging context.
_path_to_module included the root separator (/ or drive letter) when converting absolute paths to dotted module names, producing /.tmp.project.main instead of tmp.project.main.
Replace _is_subpath helper with Path.is_relative_to() (available since 3.9), removing the double relative_to() call.
Rename "Full Paths" to "File Paths", remove basename-only
.split('/').pop() so tooltip, hotspots, and search all show the
same path in file-paths mode.
Display module names instead of full file paths (/home/user/project/pkg/mod.py → pkg.mod) in flamegraph for readability.
CC: @pablogsal @lkollar
The issue: