[3.14] gh-145177: Add emscripten run --test, uses test args from config.toml (GH-146160) - #146186
Merged
freakboy3742 merged 1 commit intoMar 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…g.toml (pythonGH-146160) This allows us to change the test arguments from the python repo rather than having to change buildmaster-config. (cherry picked from commit 6b5511d) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com> Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742
approved these changes
Mar 19, 2026
freakboy3742
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
👍
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @miss-islington for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @miss-islington and @freakboy3742, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker bc6edf835008ed967f9af450d14fe1452514de7c 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
/me facepalms backporting a 3.14 PR to 3.14... |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to change the test arguments from the python repo rather
than having to change buildmaster-config.
(cherry picked from commit 6b5511d)
Co-authored-by: Hood Chatham roberthoodchatham@gmail.com
Co-authored-by: Russell Keith-Magee russell@keith-magee.com