move root checks to test.support by kulikjak · Pull Request #146195 · python/cpython · GitHub

Hi, when looking into unrelated changes, I realized that the check for root privilege is duplicated on several places and can be moved to test.support.

This change also improves test_ownership_after_flush because without root, it skips it before running potentially slow pwd.getpwall.

I am unsure whether this is trivial enough to not require an issue - I am happy to create one if that is not the case.

Can you rename these decorators to requires_root_user and requires_non_root_user? At the first look, I wasn't sure what "root" was about. Root window? Root what? :-) Or maybe requires_root_privilege?

Ah, you are right - I guess there are several roots :)

LGTM

"Tests / All required checks pass" failed with:

Error: The template is not valid. .github/workflows/build.yml (Line: 687, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.

Let me click on [Update branch] to try to fix it.

Merged, thanks for tests enhancements.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 86b8617.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/13827) and take a look at the build logs.
Check if the failure is related to this commit (86b8617) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/13827

Failed tests:

test_pathlib

Failed subtests:

test_copy_dir_no_read_permission - test.test_pathlib.test_pathlib.PathSubclassTest.test_copy_dir_no_read_permission
test_copy_dir_no_read_permission - test.test_pathlib.test_pathlib.PosixPathTest.test_copy_dir_no_read_permission
test_copy_dir_no_read_permission - test.test_pathlib.test_pathlib.PathTest.test_copy_dir_no_read_permission

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_pathlib/test_pathlib.py", line 1558, in test_copy_dir_no_read_permission
    self.assertRaises(PermissionError, source.copy, target)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: PermissionError not raised by copy

Will you be able to fix the failure today?
If not, let's revert so the buildbot can find other issues.

Hi, sorry about that. I am looking into it and will try to fix it ASAP.

Sorry, it was a silly little mistake - #148028 should fix it.

This fixes a bug introduced in commit 86b8617 (GH-146195).

Yea, I posted before looking at the code, and before coffee :)
Thank you for the fix!

Oops, I missed that in the review. Hopefully, we have a buildbot running as root (AMD64 Debian root 3.x) which catched the regression. Thanks for fixing the regression.

) This fixes a bug introduced in commit 86b8617 (pythonGH-146195).

This partially backports commit 86b8617 (pythonGH-146195); making existing tests use the helper is omitted.

…raryDirectory (GH-157580) (#158489) * gh-157579: Fix race condition in the cleanup of `tempfile.TemporaryDirectory` (GH-157580) (cherry picked from commit 5c20517) * Add root user checks to test.support This partially backports commit 86b8617 (GH-146195); making existing tests use the helper is omitted. * gh-134993: Add os.lstat() to os.supports_dir_fd (#135188) Co-authored-by: Stan Ulbrych <stan@python.org> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Petr Viktorin <encukou@gmail.com>

…oraryDirectory` (GH-157580) (GH-158430) * gh-157579: Fix race condition in the cleanup of `tempfile.TemporaryDirectory` (GH-157580) (cherry picked from commit 5c20517) * Add root user checks to test.support This partially backports commit 86b8617 (GH-146195); making existing tests use the helper is omitted. --------- Co-authored-by: Stan Ulbrych <stan@python.org> Co-authored-by: Petr Viktorin <encukou@gmail.com>

kulikjak added 2 commits March 19, 2026 14:42

move root checks to test.support

001f6db

remove unrelated changes

2d6b2d5

kulikjak requested review from a team and barneygale as code owners March 20, 2026 08:27

bedevere-app Bot added the awaiting review label Mar 20, 2026

vstinner reviewed Mar 27, 2026

View reviewed changes

remove the new decorators to better names

ed4e92a

vstinner approved these changes Mar 31, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 31, 2026

vstinner added skip issue skip news labels Mar 31, 2026

vstinner enabled auto-merge (squash) March 31, 2026 09:47

Merge branch 'main' into tests-root-improvements

d569149

Merge branch 'main' into tests-root-improvements

a1b9465

vstinner merged commit 86b8617 into python:main Apr 2, 2026
48 checks passed

bedevere-app Bot removed the awaiting merge label Apr 2, 2026

kulikjak mentioned this pull request Apr 3, 2026

test_copy_dir_no_read_permission requires non root user #148028

Merged

encukou pushed a commit that referenced this pull request Apr 3, 2026

test_copy_dir_no_read_permission requires non root user (GH-148028 )

3908593

This fixes a bug introduced in commit 86b8617 (GH-146195).

pablogsal mentioned this pull request Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Merged

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026

Move root user checks to test.support (python#146195 )

db4a2f3

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026

test_copy_dir_no_read_permission requires non root user (pythonGH-148028

6b9e8b0

) This fixes a bug introduced in commit 86b8617 (pythonGH-146195).

encukou added a commit to miss-islington/cpython that referenced this pull request Sep 30, 2026

Add root user checks to test.support

fb187f1

This partially backports commit 86b8617 (pythonGH-146195); making existing tests use the helper is omitted.

encukou added a commit to miss-islington/cpython that referenced this pull request Sep 30, 2026

Add root user checks to test.support

8da0b0a

This partially backports commit 86b8617 (pythonGH-146195); making existing tests use the helper is omitted.

encukou mentioned this pull request Oct 9, 2026

[3.12] gh-157579: Fix race condition in the cleanup of tempfile.TemporaryDirectory (GH-157580) (GH-158430) #159074

Open

move root checks to test.support by kulikjak · Pull Request #146195 · python/cpython · GitHub

Repository navigation

move root checks to test.support - #146195

move root checks to test.support#146195
vstinner merged 5 commits into
python:mainfrom
kulikjak:tests-root-improvements

kulikjak commented Mar 20, 2026

Uh oh!

vstinner Mar 27, 2026

Uh oh!

kulikjak Mar 31, 2026

Uh oh!

vstinner left a comment

Uh oh!

vstinner commented Apr 1, 2026

Uh oh!

Uh oh!

vstinner commented Apr 2, 2026

Uh oh!

bedevere-bot commented Apr 2, 2026

Uh oh!

encukou commented Apr 3, 2026

Uh oh!

kulikjak commented Apr 3, 2026

Uh oh!

kulikjak commented Apr 3, 2026

Uh oh!

encukou commented Apr 3, 2026

Uh oh!

vstinner commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants



		_ROOT_IN_POSIX = hasattr(os, 'geteuid') and os.geteuid() == 0
		requires_root = unittest.skipUnless(_ROOT_IN_POSIX, "test needs root privilege")

move root checks to test.support by kulikjak · Pull Request #146195 · python/cpython · GitHub

Repository navigation

move root checks to test.support - #146195

move root checks to test.support#146195vstinner merged 5 commits intopython:mainpython/cpython:mainfrom kulikjak:tests-root-improvementskulikjak/cpython:tests-root-improvementsCopy head branch name to clipboard

Conversation

kulikjak commented Mar 20, 2026

Uh oh!

vstinner Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

kulikjak Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Apr 1, 2026

Uh oh!

Uh oh!

vstinner commented Apr 2, 2026

Uh oh!

bedevere-bot commented Apr 2, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

encukou commented Apr 3, 2026

Uh oh!

kulikjak commented Apr 3, 2026

Uh oh!

kulikjak commented Apr 3, 2026

Uh oh!

encukou commented Apr 3, 2026

Uh oh!

vstinner commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

move root checks to test.support#146195
vstinner merged 5 commits into
python:mainfrom
kulikjak:tests-root-improvements