Repository navigation
gh-146292: Add colour to http.server logs - #146293
Merged
ambv merged 8 commits intoApr 8, 2026
Merged
ambv merged 8 commits into
ambv merged 8 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Doc/whatsnew/3.15.rst
Outdated
Comment thread
Doc/whatsnew/3.15.rst
Outdated
Comment thread
Doc/whatsnew/3.15.rst
Outdated
Comment thread
Doc/whatsnew/3.15.rst
Outdated
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
picnixz
reviewed
Mar 22, 2026
Comment thread
Lib/test/test_httpservers.py
Outdated
Comment thread
Lib/http/server.py
Comment thread
Lib/_colorize.py
Outdated
hugovk
commented
Apr 6, 2026
Comment thread
Lib/_colorize.py
Copy link
Copy Markdown
Member
Author
|
@picnixz @brianschubert Thanks for the reviews! Any further comments? |
Sorry, something went wrong.
AlexWaygood
removed their request for review
April 6, 2026 21:43
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking inspiration from the make dev logs for the new blog (https://github.com/python/python-insider-blog):
Let's add colour to the http.server log output:
As usual, this respects the environment variables to control colour and the output stream's capabilities.
📚 Documentation preview 📚: https://cpython-previews--146293.org.readthedocs.build/