FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version by chris-eibl · Pull Request #146338 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version - #146338

Merged
savannahostrowski merged 5 commits into
python:mainfrom
chris-eibl:gh146210
Apr 3, 2026
ConversationCommits (5)ChecksFiles changed
Merged

GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version#146338
savannahostrowski merged 5 commits into
python:mainfrom
chris-eibl:gh146210

Conversation

chris-eibl commented Mar 23, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

By dropping the environment variable INCLUDE when building the jit stencils. Since this is Windows specific, this is only done on Windows.

fix building the jit stencils on Windows when the
390cc8a 
interpreter is built with a different clang version.
bedevere-app Bot mentioned this pull request Mar 23, 2026
Closed
savannahostrowski requested changes Apr 3, 2026
View reviewed changes

savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for taking a look at this!

Comment thread Tools/jit/_llvm.py Outdated
Comment thread Tools/jit/_llvm.py

bedevere-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

savannahostrowski approved these changes Apr 3, 2026
View reviewed changes

savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

savannahostrowski merged commit dea4083 into python:main Apr 3, 2026
78 checks passed
chris-eibl deleted the gh146210 branch April 3, 2026 19:43
pablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythonGH-146210: Fix building the jit stencils on Windows when the in…
443237d 
…terpreter is built with a different clang version (python#146338)

Co-authored-by: Savannah Ostrowski <savannah@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

savannahostrowski savannahostrowski approved these changes
brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
diegorusso Awaiting requested review from diegorusso diegorusso is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL