gh-146197: Include a bit more information in sys._emscripten_info.runtime - #146346
Merged
vstinner merged 1 commit intoMar 23, 2026
Merged
gh-146197: Include a bit more information in sys._emscripten_info.runtime#146346vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
pythoninfo of the Emscripten CI job says: sys._emscripten_info: sys._emscripten_info(emscripten_version=(4, 0, 12), runtime='node v24.14.0 (v8 13.6.233.17-node.41)', pthreads=False, shared_memory=False)
I'm not sure that it's a good idea to change sys._emscripten_info.runtime in a Python 3.14.x bugfix release. Some projects may rely on the current string format. |
Sorry, something went wrong.
vstinner
approved these changes
Mar 23, 2026
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. But it may safer to not backport the change to 3.14.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Right, I suppose we don't need the backport for anything. |
Sorry, something went wrong.
vstinner
enabled auto-merge (squash)
March 23, 2026 21:50
CuriousLearner
added a commit
to CuriousLearner/cpython
that referenced
this pull request
Mar 24, 2026
…on into fix-pythongh-138577 * 'fix-pythongh-138577' of github.com:CuriousLearner/cpython: pythongh-146202: Create tmp_dir in regrtest worker (python#146347) pythongh-144319: obtain SeLockMemoryPrivilege on Windows (python#144928) pythongh-146199: Fix error handling in `code_richcompare` when `PyObject_RichCompareBool` fails (python#146200) pythongh-146197: Include a bit more information in sys._emscripten_info.runtime (python#146346) pythongh-135871: Reload lock internal state while spinning in `PyMutex_LockTimed` (pythongh-146064) pythongh-145719: Add `.efi` file detection in `mimetypes` (python#145720)
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Apr 16, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: sys._emscripten_info.runtime is Node.js/24, now it says node v24.14.0 (v8 13.6.233.17-node.41). I also added detection for node and bun.