FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-143930: Reject leading dashes in webbrowser URLs by Pinky-Chaudhary · Pull Request #146360 · python/cpython · GitHub

/ cpython Public

[3.12] gh-143930: Reject leading dashes in webbrowser URLs - #146360

Merged
ambv merged 2 commits into
python:3.12from
Pinky-Chaudhary:backport-82a24a4-3.12
Mar 24, 2026
ConversationCommits (2)ChecksFiles changed
Merged

[3.12] gh-143930: Reject leading dashes in webbrowser URLs#146360
ambv merged 2 commits into
python:3.12from
Pinky-Chaudhary:backport-82a24a4-3.12

Conversation

Pinky-Chaudhary commented Mar 24, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

bedevere-app Bot mentioned this pull request Mar 24, 2026
Closed
Pinky-Chaudhary changed the title gh-143930: Reject leading dashes in webbrowser URLs [3.12] gh-143930: Reject leading dashes in webbrowser URLs Mar 24, 2026
ambv requested changes Mar 24, 2026
View reviewed changes

ambv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The backport needs to be equivalent to what was landed in 3.13 - 3.15. Don't make any other changes.

bedevere-app Bot commented Mar 24, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

python-cla-bot Bot commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

Pinky-Chaudhary commented Mar 24, 2026

Copy link
Copy Markdown
Author

I have made the requested changes; please review again

bedevere-app Bot commented Mar 24, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@ambv: please review the changes made to this pull request.

bedevere-app Bot requested a review from ambv March 24, 2026 18:33
ambv merged commit cbba611 into python:3.12 Mar 24, 2026
29 of 32 checks passed

ambv commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Thanks, @Pinky-Chaudhary!

Pinky-Chaudhary deleted the backport-82a24a4-3.12 branch March 25, 2026 05:06
hroncok pushed a commit to fedora-python/cpython that referenced this pull request Mar 26, 2026
00478: CVE-2026-4519
196302b 
Reject leading dashes in webbrowser URLs (pythonGH-146360)

(cherry picked from commit 82a24a4)

Co-authored-by: Seth Michael Larson <seth@python.org>
stratakis pushed a commit to stratakis/cpython that referenced this pull request Apr 16, 2026
00478: CVE-2026-4519
e51fc65 
Reject leading dashes in webbrowser URLs (pythonGH-146360)

(cherry picked from commit 82a24a4)

Co-authored-by: Seth Michael Larson <seth@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL