FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-138573: filter out failing math tests on Solaris by skirpichev · Pull Request #146402 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-138573: filter out failing math tests on Solaris - #146402

Merged
vstinner merged 1 commit into
python:mainfrom
skirpichev:filter-math-tests-on-sunos/138573
Mar 25, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-138573: filter out failing math tests on Solaris#146402
vstinner merged 1 commit into
python:mainfrom
skirpichev:filter-math-tests-on-sunos/138573

Conversation

skirpichev commented Mar 25, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Mar 25, 2026
bedevere-app Bot mentioned this pull request Mar 25, 2026
Closed
vstinner added the needs backport to 3.14 bugs and security fixes label Mar 25, 2026

vstinner commented Mar 25, 2026

Copy link
Copy Markdown
Member

I can see the test_math.testAtan2() and test_cmath.test_phase() failures on the Solaris buildbot: https://buildbot.python.org/#/builders/742/builds/9890

ERROR: testAtan2 (test.test_math.MathTests.testAtan2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/share/buildbot-worker/python/3.x.kulikjak-solaris-sparcv9/build/Lib/test/test_math.py", line 306, in testAtan2
    self.ftest('atan2(0., -0.)', math.atan2(0., -0.), math.pi)
                                 ~~~~~~~~~~^^^^^^^^^
ValueError: math domain error

and

ERROR: test_phase (test.test_cmath.CMathTests.test_phase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/share/buildbot-worker/python/3.x.kulikjak-solaris-sparcv9/build/Lib/test/test_cmath.py", line 410, in test_phase
    self.assertAlmostEqual(phase(0), 0.)
                           ~~~~~^^^
ValueError: math domain error

vstinner commented Mar 25, 2026

Copy link
Copy Markdown
Member

There are the two same errors on the 3.14 Solaris buildbot: https://buildbot.python.org/#/builders/1804/builds/808. So we can backport this change to 3.14.

On the 3.13 Solaris buildbot, test_math and test_cmath pass, so there is no need to backport to 3.13.

vstinner merged commit 8e1469c into python:main Mar 25, 2026
54 checks passed

miss-islington-app Bot commented Mar 25, 2026

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2026
pythongh-138573: Filter out failing math tests on Solaris (pythonGH-1…
466ff99 
…46402)

(cherry picked from commit 8e1469c)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

bedevere-app Bot commented Mar 25, 2026

Copy link
Copy Markdown

GH-146438 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 25, 2026
skirpichev deleted the filter-math-tests-on-sunos/138573 branch March 25, 2026 23:13
vstinner pushed a commit that referenced this pull request Mar 26, 2026
[3.14] gh-138573: Filter out failing math tests on Solaris (GH-146402) (
7efa72a 
#146438)

gh-138573: Filter out failing math tests on Solaris (GH-146402)
(cherry picked from commit 8e1469c)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
pablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
pythongh-138573: Filter out failing math tests on Solaris (python#146402
3989081 
)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-138573: Filter out failing math tests on Solaris (python#146402
7cd988b 
)
hpkfft mentioned this pull request Jul 6, 2026
Open
hpkfft added a commit to hpkfft/cpython that referenced this pull request Aug 14, 2026
Revert pythongh-146402 and update NEWS entry
43f7398 
This reverts commit 8e1469c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL