FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143930: Tweak the exception message and increase test coverage by ambv · Pull Request #146476 · python/cpython · GitHub

/ cpython Public

gh-143930: Tweak the exception message and increase test coverage - #146476

Merged
ambv merged 5 commits into
python:mainfrom
ambv:gh-143930-followup
Apr 3, 2026
ConversationCommits (5)ChecksFiles changed
Merged

gh-143930: Tweak the exception message and increase test coverage#146476
ambv merged 5 commits into
python:mainfrom
ambv:gh-143930-followup

Conversation

ambv commented Mar 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Based on comments left by Copilot on the backport PRs, there's two minor improvements that I made to the original vulnerability fix.

ambv added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 26, 2026
ambv added the skip news label Mar 26, 2026
ambv requested a review from sethmlarson March 26, 2026 17:20
bedevere-app Bot mentioned this pull request Mar 26, 2026
Closed
sethmlarson reviewed Mar 26, 2026
View reviewed changes
Comment thread Lib/test/test_webbrowser.py Outdated
StanFromIreland mentioned this pull request Mar 31, 2026
Closed

picnixz commented Mar 31, 2026

Copy link
Copy Markdown
Member

@ambv Before merging can you include the changes in #147948 please?

picnixz commented Mar 31, 2026

Copy link
Copy Markdown
Member

Adding a DO-NOT-MERGE so that you don't forget about it.

ambv merged commit 3681d47 into python:main Apr 3, 2026
51 checks passed

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2026
pythongh-143930: Tweak the exception message and increase test covera…
f7a9aca 
…ge (pythonGH-146476)

(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3681d47a440865aead912a054d4599087b4270dd 3.13

bedevere-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

GH-148042 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Apr 3, 2026

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3681d47a440865aead912a054d4599087b4270dd 3.12

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3681d47a440865aead912a054d4599087b4270dd 3.11

miss-islington-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

Sorry, @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3681d47a440865aead912a054d4599087b4270dd 3.10

ambv added a commit that referenced this pull request Apr 3, 2026
[3.14] gh-143930: Tweak the exception message and increase test cover…
594b5a0 
…age (GH-146476) (GH-148042)

(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit to ambv/cpython that referenced this pull request Apr 3, 2026
[3.13] pythongh-143930: Tweak the exception message and increase test…
a43f367 
… coverage (pythonGH-146476)

(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

GH-148045 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 3, 2026
ambv added a commit that referenced this pull request Apr 3, 2026
[3.13] gh-143930: Tweak the exception message and increase test cover…
89bfb8e 
…age (GH-146476) (GH-148045)

(cherry picked from commit 3681d47)
ambv removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Apr 3, 2026
ambv added a commit to ambv/cpython that referenced this pull request Apr 3, 2026
[3.12] pythongh-143930: Tweak the exception message and increase test…
d11a500 
… coverage (pythonGH-146476) (pythonGH-148045)

(cherry picked from commit 89bfb8e)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 3681d47)
ambv added a commit that referenced this pull request Apr 3, 2026
[3.12] gh-143930: Tweak the exception message and increase test cover…
cc02351 
…age (GH-146476) (GH-148045) (GH-148051)

(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2026
[3.12] pythongh-143930: Tweak the exception message and increase test…
e1dbc72 
… coverage (pythonGH-146476) (pythonGH-148045) (pythonGH-148051)

(cherry picked from commit cc02351)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2026
[3.12] pythongh-143930: Tweak the exception message and increase test…
0e0506c 
… coverage (pythonGH-146476) (pythonGH-148045) (pythonGH-148051)

(cherry picked from commit cc02351)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)
ambv added a commit that referenced this pull request Apr 3, 2026
[3.10] gh-143930: Tweak the exception message and increase test cover…
591ed89 
…age (GH-146476) (GH-148045) (GH-148051) (GH-148053)

(cherry picked from commit cc02351)
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Apr 3, 2026
[3.11] gh-143930: Tweak the exception message and increase test cover…
96fc504 
…age (GH-146476) (GH-148045) (GH-148051) (GH-148052)

(cherry picked from commit cc02351)
(cherry picked from commit 89bfb8e)
(cherry picked from commit 3681d47)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
pablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-143930: Tweak the exception message and increase test covera…
ec82537 
…ge (pythonGH-146476)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sethmlarson sethmlarson left review comments

Assignees

ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL