Repository navigation
gh-138580: revert PR 138811 - #146501
Merged
vstinner merged 1 commit intoMar 27, 2026
Merged
gh-138580: revert PR 138811#146501vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This reverts commit 68c7fad.
Copy link
Copy Markdown
Member
|
Can you please provide a rationale for the revert? So I can put it in the commit message. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Description updated. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Ok, I merged the PR to revert the flag. Bye bye ISO/IEC 60559. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks, and sorry for the noise.
I think that the possible reason for poor adoption was that this flag mess
libc and compiler capabilities.
…On Fri, Mar 27, 2026, 13:31 Victor Stinner ***@***.***> wrote:
*vstinner* left a comment (python/cpython#146501)
<#146501?email_source=notifications&email_token=AAQOKGBZKBCUGIRNAHUQOQL4SZJ7JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGE3DKNBQGA2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4141654004>
Ok, I merged the PR to revert the flag. Bye bye ISO/IEC 60559.
—
Reply to this email directly, view it on GitHub
<#146501?email_source=notifications&email_token=AAQOKGBZKBCUGIRNAHUQOQL4SZJ7JA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJUGE3DKNBQGA2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4141654004>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQOKGCPCCQM7ZSXVGNZXNL4SZJ7JAVCNFSM6AAAAACXBHPULCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCNBRGY2TIMBQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hum, I also expect that it's a lot of work to make sure that libm implementation is fully compliant. And it seems like not all libm maintainers can enough to do this work. |
Sorry, something went wrong.
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Apr 16, 2026
…#146501) This reverts commit 68c7fad. It looks like on practice the __STDC_IEC_559__ doesn't indicate conformance to the standard. It can't be used to filter out tests or to give some promises in documentation. See discussion in the reverted PR thread: python#138811 (comment)
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…#146501) This reverts commit 68c7fad. It looks like on practice the __STDC_IEC_559__ doesn't indicate conformance to the standard. It can't be used to filter out tests or to give some promises in documentation. See discussion in the reverted PR thread: python#138811 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 68c7fad.
It looks like on practice the __STDC_IEC_559__ doesn't indicate conformance to the standard. It can't be used to filter out tests or to give some promises in documentation. See discussion in the reverted PR thread:
#138811 (comment)
📚 Documentation preview 📚: https://cpython-previews--146501.org.readthedocs.build/