FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-126910: reserve FP on AArch64 when generating JIT stencils by diegorusso · Pull Request #146520 · python/cpython · GitHub

/ cpython Public

GH-126910: reserve FP on AArch64 when generating JIT stencils - #146520

Merged
Fidget-Spinner merged 4 commits into
python:mainfrom
diegorusso:reserve-fp-aarch64
Mar 27, 2026
ConversationCommits (4)ChecksFiles changed
Merged

GH-126910: reserve FP on AArch64 when generating JIT stencils#146520
Fidget-Spinner merged 4 commits into
python:mainfrom
diegorusso:reserve-fp-aarch64

Conversation

diegorusso commented Mar 27, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This is a follow up of #143548

This is needed for #146071

bedevere-app Bot mentioned this pull request Mar 27, 2026
Open
diegorusso mentioned this pull request Mar 27, 2026
Merged
brandtbucher reviewed Mar 27, 2026
View reviewed changes

brandtbucher left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cool! Two questions:

  • Has anyone actually tested that this works (and is necessary) for unwinding on macOS or Windows? If not, I'd be inclined to drop those from this PR.
  • why -fno-unwind-table everywhere now?

diegorusso commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author
  • why -fno-unwind-table everywhere now?

Fair point. Without it, stencils generation fails on Darwin because they introduce new relocation like ARM64_RELOC_SUBTRACTOR

On Darwin, -fno-asynchronous-unwind-tables is not enough by itself: clang can still emit .cfi_* in the assembly and produce __compact_unwind / __eh_frame in the object.

I thought to put it everywhere because the JIT stencils do not use object-file unwind metadata at all.

If you prefer I can put it on Darwin AArch64 only.

diegorusso commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Cool! Two questions:

  • Has anyone actually tested that this works (and is necessary) for unwinding on macOS or Windows? If not, I'd be inclined to drop those from this PR.
  • why -fno-unwind-table everywhere now?

I've update the PR to do it just on Linux AArch64. macOS requires more investigation as the code generation is slightly different.
I've removed the -fno-unwind-table as well.

Fidget-Spinner merged commit 6763d26 into python:main Mar 27, 2026
75 checks passed
pablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
pythonGH-126910: reserve FP on AArch64 when generating JIT stencils (p…
1c54d54 
…ythonGH-146520)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythonGH-126910: reserve FP on AArch64 when generating JIT stencils (p…
9dcfb64 
…ythonGH-146520)
diegorusso deleted the reserve-fp-aarch64 branch May 5, 2026 08:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher left review comments
Fidget-Spinner Fidget-Spinner approved these changes
markshannon Awaiting requested review from markshannon
savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL