FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-142518: add thread safety docs for set C-APIs by kumaraditya303 · Pull Request #146562 · python/cpython · GitHub

/ cpython Public

gh-142518: add thread safety docs for set C-APIs - #146562

Merged
kumaraditya303 merged 9 commits into
python:mainfrom
kumaraditya303:set-capi
Apr 10, 2026
ConversationCommits (9)ChecksFiles changed
Merged

gh-142518: add thread safety docs for set C-APIs#146562
kumaraditya303 merged 9 commits into
python:mainfrom
kumaraditya303:set-capi

Conversation

kumaraditya303 commented Mar 28, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Mar 28, 2026
Closed
kumaraditya303 requested a review from vstinner March 31, 2026 11:41
vstinner reviewed Mar 31, 2026
View reviewed changes
Comment thread Doc/c-api/set.rst Outdated
Comment thread Doc/data/threadsafety.dat
Comment thread Doc/data/threadsafety.dat Outdated
Comment thread Doc/data/threadsafety.dat Outdated
kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Apr 2, 2026
kumaraditya303 requested a review from vstinner April 2, 2026 10:59
vstinner approved these changes Apr 7, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Doc/data/threadsafety.dat
kumaraditya303 and others added 2 commits April 9, 2026 20:51
Update Doc/data/threadsafety.dat
cce95cc 
Co-authored-by: Victor Stinner <vstinner@python.org>
align set docs with dict
1d5ab85
vstinner reviewed Apr 10, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread Doc/data/threadsafety.dat
@@ -125,6 +125,29 @@ PyByteArray_GET_SIZE:atomic:
PyByteArray_AsString:compatible:
PyByteArray_AS_STRING:compatible:

vstinner Apr 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You may add PySet_Check(), PyFrozenSet_Check(), PyAnySet_Check(), PySet_CheckExact(), PyAnySet_CheckExact() and PyFrozenSet_CheckExact() functions, they are atomic.

kumaraditya303 Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am thinking of covering this and other type checks in next PR, so skipping this for now

Comment thread Doc/data/threadsafety.dat Outdated
Update Doc/data/threadsafety.dat
14101e5 
Co-authored-by: Victor Stinner <vstinner@python.org>
kumaraditya303 enabled auto-merge (squash) April 10, 2026 19:27
kumaraditya303 merged commit dd88e77 into python:main Apr 10, 2026
30 checks passed

miss-islington-app Bot commented Apr 10, 2026

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2026
pythongh-142518: add thread safety docs for set C-APIs (pythonGH-146562)
2839ee1 
(cherry picked from commit dd88e77)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app Bot commented Apr 10, 2026

Copy link
Copy Markdown

GH-148362 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Apr 10, 2026
kumaraditya303 deleted the set-capi branch April 10, 2026 19:40
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Apr 11, 2026
pythongh-142518: add thread safety docs for set C-APIs (python#146562)
c735c36 
Co-authored-by: Victor Stinner <vstinner@python.org>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-142518: add thread safety docs for set C-APIs (python#146562)
0cbec12 
Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL