Repository navigation
CYGWIN: fix "defined but not used" warnings on mimalloc - #146572
carlo-bramini wants to merge 1 commit into
Conversation
Sorry, something went wrong.
Compiling under CYGWIN prints these warning messages:
In file included from ../cpython/Objects/mimalloc/prim/prim.c:22,
from ../cpython/Objects/mimalloc/static.c:37,
from ../cpython/Objects/obmalloc.c:23:
../cpython/Objects/mimalloc/prim/unix/prim.c:91:12: warning: ‘mi_prim_access’ defined but not used [-Wunused-function]
91 | static int mi_prim_access(const char *fpath, int mode) {
| ^~~~~~~~~~~~~~
../cpython/Objects/mimalloc/prim/unix/prim.c:88:12: warning: ‘mi_prim_close’ defined but not used [-Wunused-function]
88 | static int mi_prim_close(int fd) {
| ^~~~~~~~~~~~~
../cpython/Objects/mimalloc/prim/unix/prim.c:85:16: warning: ‘mi_prim_read’ defined but not used [-Wunused-function]
85 | static ssize_t mi_prim_read(int fd, void* buf, size_t bufsize) {
| ^~~~~~~~~~~~
../cpython/Objects/mimalloc/prim/unix/prim.c:82:12: warning: ‘mi_prim_open’ defined but not used [-Wunused-function]
82 | static int mi_prim_open(const char* fpath, int open_flags) {
| ^~~~~~~~~~~~
Looking into the code of Objects/mimalloc/prim/unix/prim.c, there is already a conditional block to avoid the generation of such warnings.
Unfortunately, CYGWIN is missing in this list.
However, adding it is very easy and the change is self-explanatory, as you can see.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
|
Please report those issues upstream. mimalloc is a vendored copy which we do not modify. |
Sorry, something went wrong.
Excuse me, probably I'm doing a mistake but this doesn't appear to be true. and those fixes are not available into the upstream of mimalloc, by reading the code at https://github.com/microsoft/mimalloc. |
Sorry, something went wrong.
|
Oh, my bad. I thought we legally needed to do this actually, my bad. Please open a new PR (the branch/repo seems to be deleted so I can't reopen the PR) |
Sorry, something went wrong.
|
Hum. I am not sure actually. Because ae968d1 has an upstream patch. Let me check. |
Sorry, something went wrong.
|
See #113141 as well. Now, I'd suggest that you first open an issue so that we can properly track this change. |
Sorry, something went wrong.
Compiling under CYGWIN prints these warning messages:
In file included from ../cpython/Objects/mimalloc/prim/prim.c:22, from ../cpython/Objects/mimalloc/static.c:37, from ../cpython/Objects/obmalloc.c:23: ../cpython/Objects/mimalloc/prim/unix/prim.c:91:12: warning: ‘mi_prim_access’ defined but not used [-Wunused-function] 91 | static int mi_prim_access(const char *fpath, int mode) { | ^~~~~~~~~~~~~~ ../cpython/Objects/mimalloc/prim/unix/prim.c:88:12: warning: ‘mi_prim_close’ defined but not used [-Wunused-function] 88 | static int mi_prim_close(int fd) { | ^~~~~~~~~~~~~ ../cpython/Objects/mimalloc/prim/unix/prim.c:85:16: warning: ‘mi_prim_read’ defined but not used [-Wunused-function] 85 | static ssize_t mi_prim_read(int fd, void* buf, size_t bufsize) { | ^~~~~~~~~~~~ ../cpython/Objects/mimalloc/prim/unix/prim.c:82:12: warning: ‘mi_prim_open’ defined but not used [-Wunused-function] 82 | static int mi_prim_open(const char* fpath, int open_flags) { | ^~~~~~~~~~~~Looking into the code of Objects/mimalloc/prim/unix/prim.c, there is already a conditional block to avoid the generation of such warnings.
Unfortunately, CYGWIN is missing in this list.
However, adding it is very easy and the change is self-explanatory, as you can see.