FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-146615: Fix format specifiers in extension modules by sunmy2019 · Pull Request #146617 · python/cpython · GitHub

/ cpython Public

gh-146615: Fix format specifiers in extension modules - #146617

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
sunmy2019:gh-146615-2
Mar 31, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-146615: Fix format specifiers in extension modules#146617
serhiy-storchaka merged 3 commits into
python:mainfrom
sunmy2019:gh-146615-2

Conversation

sunmy2019 commented Mar 30, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Mar 30, 2026
Closed
sunmy2019 mentioned this pull request Mar 30, 2026
Closed
emmatyping reviewed Mar 30, 2026
View reviewed changes
Comment thread Modules/_zstd/compressor.c
serhiy-storchaka reviewed Mar 30, 2026
View reviewed changes
Comment thread Modules/_ssl.c
Comment thread Modules/_ssl.c Outdated
Comment thread Modules/_ssl.c Outdated

picnixz commented Mar 30, 2026

Copy link
Copy Markdown
Member

See #146620 (comment) for the rationale of skip news

serhiy-storchaka approved these changes Mar 30, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 30, 2026
serhiy-storchaka marked this pull request as ready for review March 30, 2026 17:10
StanFromIreland approved these changes Mar 30, 2026
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM for _zoneinfo.c

kumaraditya303 approved these changes Mar 30, 2026
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

asyncio changes LGTM.

serhiy-storchaka merged commit 1c396e1 into python:main Mar 31, 2026
65 checks passed

miss-islington-app Bot commented Mar 31, 2026

Copy link
Copy Markdown

Thanks @sunmy2019 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Mar 31, 2026

Copy link
Copy Markdown

Sorry, @sunmy2019 and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1c396e18218daa723b425af0781c5e762d7717c2 3.14

miss-islington-app Bot commented Mar 31, 2026

Copy link
Copy Markdown

Sorry, @sunmy2019 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1c396e18218daa723b425af0781c5e762d7717c2 3.13

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
[3.14] pythongh-146615: Fix format specifiers in extension modules (p…
bdb9d8a 
…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>

bedevere-app Bot commented Mar 31, 2026

Copy link
Copy Markdown

GH-146652 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 31, 2026
serhiy-storchaka removed the needs backport to 3.13 bugs and security fixes label Mar 31, 2026
serhiy-storchaka removed their assignment Mar 31, 2026
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
[3.14] pythongh-146615: Fix format specifiers in extension modules (p…
e3e88c7 
…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
[3.14] pythongh-146615: Fix format specifiers in extension modules (p…
de63d17 
…ythonGH-146617)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
serhiy-storchaka added a commit that referenced this pull request Mar 31, 2026
[3.14] gh-146615: Fix format specifiers in extension modules (GH-146617…
58c7259 
…) (GH-146652)

(cherry picked from commit 1c396e1)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 31, 2026
[3.13] pythongh-146615: Fix format specifiers in extension modules (p…
6e5c933 
…ythonGH-146617) (pythonGH-146652)

(cherry picked from commit 1c396e1)
(cherry picked from commit 58c7259)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 31, 2026
Merge branch 'main' into tachyon-ndjson-kolektor
9836ffa 
* main:
  pythongh-145458: use `self.skip_idle` consistently in the tachyon profiler (python#145459)
  pythongh-146615: Fix format specifiers in Objects/ directory (pythonGH-146620)
  pythongh-146615: Fix format specifiers in Python/ directory (pythonGH-146619)
  pythongh-146615: Fix format specifiers in test cextensions (pythonGH-146618)
  pythongh-146615: Fix format specifiers in extension modules (pythonGH-146617)
  pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors with invalid type argument (pythonGH-146634)
  pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#146378)
  pythongh-146442: Fix various bugs in compiler pipeline (python#146443)
  pythongh-146238: Support half-floats in the array module (python#146242)
  pythongh-145056: Add support for merging collections.UserDict and frozendict (pythonGH-146465)
  pythongh-145056: Fix merging of collections.OrderedDict and frozendict (pythonGH-146466)
  pythongh-139633: Run netrc file permission check only once per parse (pythonGH-139634)
serhiy-storchaka added a commit that referenced this pull request Mar 31, 2026
[3.13] gh-146615: Fix format specifiers in extension modules (GH-146617…
fc1c644 
…) (GH-146652) (GH-146658)

(cherry picked from commit 1c396e1)
(cherry picked from commit 58c7259)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>

bedevere-app Bot commented Mar 31, 2026

Copy link
Copy Markdown

GH-147704 is a backport of this pull request to the 3.14 branch.

vstinner pushed a commit that referenced this pull request Apr 1, 2026
[3.14] gh-146615: Fix format specifiers in extension modules (GH-146617…
b406d85 
…) (#147704)

Fix format specifier in parse_task_name() for long result.
pablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
pythongh-146615: Fix format specifiers in extension modules (pythonGH…
de13cd4 
…-146617)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-146615: Fix format specifiers in extension modules (pythonGH…
b2573b8 
…-146617)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
emmatyping emmatyping left review comments
kumaraditya303 kumaraditya303 approved these changes
StanFromIreland StanFromIreland approved these changes
pganssle Awaiting requested review from pganssle pganssle is a code owner
gpshead Awaiting requested review from gpshead gpshead is a code owner
picnixz Awaiting requested review from picnixz picnixz is a code owner
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL