Hey @nanjekyejoannah, did you accidentally attach the wrong bpo ticket for this? 3753 seems really old and unrelated.

It seems that you have changed the file mode of several files under Lib/test. Why? I don't think those changes should be made.

I have made the requested changes; please review again.

Thanks for making the requested changes!

: please review the changes made to this pull request.

Hey @nanjekyejoannah, did you accidentally attach the wrong bpo ticket for this? 3753 seems really old and unrelated.

Yes, thanks for catching this. I made the necessary changes.

It seems that you have changed the file mode of several files under Lib/test. Why? I don't think those changes should be made.

oh yes, I have reverted this.

Overall, the change is great and seems to work as expected, but I tested it and it doesn't work as I expected:

• it doesn't report stdout/stderr on timeout
• regression: it ignores stdout/stderr on "CHILD_ERROR" whereas it was properly passed to the main process previously
• faulthandler and Popen.communicate() use the same timeout, so it's unclear which one which trigger first: I tuned timeouts to give more time to faulthandler. I prefer faulthandler since it dumps the traceback where Python was stuck, whereas Popen.communicate() timeout only returns "truncated" output with no traceback
• the timeout is reported as an exception, not as as "result"

I tried to add a commit to this PR but I wasn't allowed, so I forked this PR and created PR #15072 to add my changes on top of it.

Closing this then in favor of PR #15072