FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-146615: Fix format specifiers in Objects/ directory (GH-146620) by sunmy2019 · Pull Request #147705 · python/cpython · GitHub

/ cpython Public

[3.13] gh-146615: Fix format specifiers in Objects/ directory (GH-146620) - #147705

Merged
vstinner merged 3 commits into
python:3.13from
sunmy2019:gh-146615-7
Apr 1, 2026
ConversationCommits (3)ChecksFiles changed
Merged

[3.13] gh-146615: Fix format specifiers in Objects/ directory (GH-146620) #147705
vstinner merged 3 commits into
python:3.13from
sunmy2019:gh-146615-7

Conversation

sunmy2019 commented Mar 31, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

I found a new error specific to 3.13.

cpython/Parser/lexer/lexer.c

Lines 1107 to 1110 in fc1c644

if (the_current_tok->f_string_quote == quote &&
the_current_tok->f_string_quote_size == quote_size) {
return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'", start));
} 

-      return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'", start));
+      return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'"));

This is fixed by 6020260 in 3.14.

bedevere-app Bot mentioned this pull request Mar 31, 2026
Closed
bedevere-app Bot mentioned this pull request Mar 31, 2026
Merged
vstinner reviewed Apr 1, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. i is declared as an int.

vstinner commented Apr 1, 2026

Copy link
Copy Markdown
Member

Hum. Your PR description described a bug which is not fixed by the PR. It's misleading.

Do you plan to integrate a fix for return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'", start)); in this PR?

sunmy2019 commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

Do you plan to integrate a fix for return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'", start)); in this PR?

I’m not sure if I should fix it within this PR or address it in a separate one. What do you think?

vstinner commented Apr 1, 2026

Copy link
Copy Markdown
Member

You can update this PR to fix also the _PyTokenizer_syntaxerror() issue.

sunmy2019 commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

Done

vstinner enabled auto-merge (squash) April 1, 2026 21:30
vstinner approved these changes Apr 1, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner merged commit c0eae2a into python:3.13 Apr 1, 2026
42 checks passed

vstinner commented Apr 1, 2026

Copy link
Copy Markdown
Member

Merged, thanks for fixes.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL