Repository navigation
bpo-29243: Fix Makefile with respect to --enable-optimizations - #1478
vstinner merged 2 commits into
Conversation
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
I still see "all" in testall, testuniversal, quicktest, smelly, patchcheck. Please update these ones as well.
But thank you for working on this very annoying bug!
Sorry, something went wrong.
Ah, you're right, thanks for the help! I've amended the commit accordingly. |
Sorry, something went wrong.
|
I ran the following test and I only see Python compiled twice, as expected:
Command: ./configure --with-pydebug --prefix=/home/haypo/pgo --enable-optimizations vim Makefile # write "PROFILE_TASK=-c pass", just to get a quick test make make install make quicktest |
Sorry, something went wrong.
"all" target is no more used directly in Makefile
|
Can you please document the change in the Build section in Misc/NEWS? With a NEWS entry, the change will be ready to be merged. |
Sorry, something went wrong.
When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations.
|
Amended the commit with a NEWS entry! |
Sorry, something went wrong.
|
@torsava you don't need to rebase or squash the commit, at the end of the merge it will do it so :) |
Sorry, something went wrong.
|
Oh, I'm sorry, I missed the "First-time contributor" notice on GitHub. Would you mind to add your name in Misc/ACKS as well? |
Sorry, something went wrong.
Ah, thank you! I wasn't sure what the merging policy was here, and I dislike simple changes drawn out over multiple commits. (I now realise it's addressed in the contributor guide, sorry for missing that.)
Done, thanks! |
Sorry, something went wrong.
|
@torsava yes, I did this before, I also like to squash to make it clean. But that is not good for others to reviewing on GitHub when doing squashing. And there is a discussion (I dont' remember on python-dev or python-committers) about this, the final answer is: don't squash and leave to the end, you can see here for more information: devguide-pullrequest |
Sorry, something went wrong.
|
Thank you for your contrib Tomáš Orsava! This bug annoyed me, I opened a duplicate issue: http://bugs.python.org/issue29641 @torsava: Do you want to do the backports? https://docs.python.org/devguide/committing.html#backporting-changes-to-an-older-version |
Sorry, something went wrong.
Glad to have helped!
I'm having some trouble with cherry_picker and I need to be going now. However, if it can wait a few days, I would like to do the backports! |
Sorry, something went wrong.
Take your time, there is no urgency ;-) You can ping me directly, we are colleagues ;-) |
Sorry, something went wrong.
|
thank you! :) |
Sorry, something went wrong.
Source is python/cpython#1478, backported to 3.5 and 3.6.
Source is python/cpython#1478, backported to 3.5 and 3.6.
…n#1478) * bpo-29243: Fix Makefile with respect to --enable-optimizations When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations. * !squash (cherry picked from commit a1054c3)
…ythonGH-1478) * bpo-29243: Fix Makefile with respect to --enable-optimizations When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations. * !squash. (cherry picked from commit a1054c3)
…H-1478) (#1518) * bpo-29243: Fix Makefile with respect to --enable-optimizations (#1478) * bpo-29243: Fix Makefile with respect to --enable-optimizations When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations. * !squash (cherry picked from commit a1054c3) * [3.6] bpo-29243: Fix Makefile with respect to --enable-optimizations (GH-1478) * bpo-29243: Fix Makefile with respect to --enable-optimizations When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations. * !squash. (cherry picked from commit a1054c3)
…ythonGH-1478) * bpo-29243: Fix Makefile with respect to --enable-optimizations When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations. * !squash. (cherry picked from commit a1054c3)
…H-1478) (#1520) * bpo-29243: Fix Makefile with respect to --enable-optimizations When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations. * !squash. (cherry picked from commit a1054c3)
…ythonGH-1478) * bpo-29243: Fix Makefile with respect to --enable-optimizations When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations. * !squash. (cherry picked from commit a1054c3)
…H-1478) (#1522) * bpo-29243: Fix Makefile with respect to --enable-optimizations When using the Profile Guided Optimization (./configure --enable-optimizations) Python is built not only during `make` but rebuilt again during `make test`, `make install` and others. This patch fixes the issue. Note that this fix produces no change at all in the Makefile if configure is run witout --enable-optimizations. * !squash. (cherry picked from commit a1054c3)
Source is python/cpython#1478, backported to 3.5 and 3.6.
When using the Profile Guided Optimization (./configure --enable-optimizations)
Python is built not only during make but rebuilt again during make test and
make install. This patch fixes the issue.
Note that this fix produces no change at all in the Makefile if configure is
run witout --enable-optimizations.