GH-126910: Make _Py_get_machine_stack_pointer return the stack pointer - #147945
Merged
markshannon merged 4 commits intoApr 1, 2026
Merged
GH-126910: Make _Py_get_machine_stack_pointer return the stack pointer#147945markshannon merged 4 commits into
markshannon merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… to it), not the frame pointer * Make ``_Py_ReachedRecursionLimit`` inline again * Remove ``_Py_MakeRecCheck`` relacing its use with ``_Py_ReachedRecursionLimit`` * Move stack swtiching check into ``_Py_CheckRecursiveCall``
markshannon
requested review from
FFY00,
ZeroIntensity and
ericsnowcurrently
as code owners
March 31, 2026 16:48
Copy link
Copy Markdown
Member
|
Can you bump a file to trigger JIT CI to run so we can see if this breaks anything? Mainly the verifier will catch if anything is wrong. |
Sorry, something went wrong.
markshannon
requested review from
brandtbucher,
diegorusso and
savannahostrowski
as code owners
March 31, 2026 17:01
Fidget-Spinner
approved these changes
Apr 1, 2026
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Apr 2, 2026
…the stack pointer (python#147945)" This reverts commit 255026d.
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Apr 16, 2026
…k pointer (python#147945) * Make _Py_get_machine_stack_pointer return the stack pointer (or close to it), not the frame pointer * Make ``_Py_ReachedRecursionLimit`` inline again * Remove ``_Py_MakeRecCheck`` relacing its use with ``_Py_ReachedRecursionLimit`` * Move stack swtiching check into ``_Py_CheckRecursiveCall``
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…k pointer (python#147945) * Make _Py_get_machine_stack_pointer return the stack pointer (or close to it), not the frame pointer * Make ``_Py_ReachedRecursionLimit`` inline again * Remove ``_Py_MakeRecCheck`` relacing its use with ``_Py_ReachedRecursionLimit`` * Move stack swtiching check into ``_Py_CheckRecursiveCall``
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…the stack pointer (python#147945)" (pythonGH-147994) Revert "pythonGH-126910: Make `_Py_get_machine_stack_pointer` return the stack pointer (python#147945)" This reverts commit 255026d, which broke a tier-1 buildbot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(or close to it), but not the frame pointer.