FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-19180: Updated reference for RFC 1750 and RFC 3280 by chkumar246 · Pull Request #148 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-19180: Updated reference for RFC 1750 and RFC 3280 - #148

Merged
ncoghlan merged 1 commit into
python:masterfrom
chkumar246:bpo-19180
Jun 9, 2017
ConversationCommits (1)ChecksFiles changed
Merged

bpo-19180: Updated reference for RFC 1750 and RFC 3280#148
ncoghlan merged 1 commit into
python:masterfrom
chkumar246:bpo-19180

Conversation

chkumar246 commented Feb 18, 2017

Copy link
Copy Markdown
Contributor
  • RFC 1750 has been been obsoleted by RFC 4086.
  • RFC 3280 has been obsoleted by RFC 5280.
  • RFC 4366 has been obsoleted by RFC 6066.

the-knights-who-say-ni commented Feb 18, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

serhiy-storchaka added the docs Documentation in the Doc dir label Feb 18, 2017
Carreau approved these changes Feb 22, 2017
View reviewed changes

Carreau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For the little effect my review can have, I approve, and comment made by OP are correct.

RFC 4366 has been obsoleted by RFC 6066.

If another reviewer is wondering, this one is already cited a couple of lines after the end the diff.

chkumar246 commented Feb 27, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for the review. Any thing more to add to this patch?

chkumar246 commented Mar 11, 2017

Copy link
Copy Markdown
Contributor Author

@Carreau @serhiy-storchaka anything more i can improve to this patch?

serhiy-storchaka requested a review from tiran March 11, 2017 19:31

orsenthil commented Apr 4, 2017

Copy link
Copy Markdown
Member

@serhiy-storchaka - shall we move forward with this? The change looks good to me. These are See Also links which informative guidance ( like introduction to SSL/TLS from Apache site in the same list). Removing the obsolete RFC and mentioning the correct ones seems to be right thing to do.

orsenthil previously approved these changes Apr 4, 2017
View reviewed changes

serhiy-storchaka commented Apr 4, 2017

Copy link
Copy Markdown
Member

RFC references should be updated only if the ssl module actually supports new RFCs and is not sticked to obsolete RFCs. I'm not a SSL expert and don't know if it is. @tiran is an expert.

There are also other references to obsolete RFCs in ssl.rst and _ssl.c. Shouldn't they be updated too?

tiran requested changes Apr 4, 2017
View reviewed changes

tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please update inline references, too.

Also please add RFC 6125 and link it from match_hostname.

Comment thread Doc/library/ssl.rst Outdated

tiran Apr 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This RFC is referenced in the documentation of RAND_add. You need to update both occurrences.

chkumar246 Jun 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

Comment thread Doc/library/ssl.rst Outdated

tiran Apr 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

5280 is correct. Please update documentation of SSLSocket.getpeercert, too.

chkumar246 Jun 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

Comment thread Doc/library/ssl.rst Outdated

tiran Apr 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RFC 6066 is the successor to 4366. Please update documentation of HAS_SNI.

chkumar246 Jun 3, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

orsenthil dismissed their stale review April 4, 2017 14:27

@tiran's comments overrules.

ncoghlan commented May 27, 2017

Copy link
Copy Markdown
Contributor

@chkumar246 Thanks for the initial work on this at the PyCon Pune sprints. Do you think you may be able to find time to follow up on @tiran's feedback, or would you prefer that someone else pick up the change and finish up those final details?

ncoghlan commented May 28, 2017

Copy link
Copy Markdown
Contributor

Added the sprint label, as this PR was submitted at the PyCon Pune 2017 core development sprint.

chkumar246 commented Jun 2, 2017

Copy link
Copy Markdown
Contributor Author

Sorry for the late reply, I will update the PR soon.

bpo-19180: Updated reference for RFC 1750 and RFC 3280
1da8be5 
* RFC 1750 has been been obsoleted by RFC 4086.
* RFC 3280 has been obsoleted by RFC 5280.
* RFC 4366 has been obsoleted by RFC 6066.

chkumar246 commented Jun 3, 2017

Copy link
Copy Markdown
Contributor Author

@ncoghlan @tiran Thanks for the review. I have resolved the comments, please have a look.

matrixise commented Jun 9, 2017

Copy link
Copy Markdown
Member

Just add the url https://bugs.python.org/issue19180

ncoghlan merged commit 63c2c8a into python:master Jun 9, 2017

matrixise commented Jun 9, 2017

Copy link
Copy Markdown
Member

thanks @ncoghlan

ncoghlan pushed a commit to ncoghlan/cpython that referenced this pull request Jun 9, 2017
[3.6] bpo-19180: Updated references for RFC 1750, RFC 3280 & RFC 4366 (…
fe2d013 
…pythonGH-148)

* RFC 1750 has been been obsoleted by RFC 4086.
* RFC 3280 has been obsoleted by RFC 5280.
* RFC 4366 has been obsoleted by RFC 6066.
(cherry picked from commit 63c2c8a)

ncoghlan commented Jun 9, 2017

Copy link
Copy Markdown
Contributor

Backport: #2023

SonicField added a commit to SonicField/cpython that referenced this pull request Apr 26, 2026
docs: cinderx_dev oracle env-spec + W-PROTOCOL-CODIFY P11/P12
b9e20b5 
Push 61 bundle (doc-only, post push-60 100/100 PURE close).

(1) docs/cinderx-oracle-env-spec.md (NEW, 5632 B):
    Theologian-authored env-spec per supervisor 01:30:42Z PRIORITY
    directive after cinderx_dev oracle attempt failed at 01:16:27Z
    (-X jit didn't activate JIT + cross-arch confound). Spec covers
    build equivalence, JIT activation verification (force_compile +
    is_jit_compiled, NOT -X jit alone), test-harness equivalence,
    warmup threshold handling, observed failure modes, application
    procedure for W-PERF-PRE-W27C-BISECT.

(2) docs/w-protocol-codify-spec.md (P11 + P12):
    P11 — cinderx_dev Oracle Environment Specification: rule that any
    cinderx_dev oracle invocation MUST follow env-spec procedure.
    Origin: pythia D-1777065234 python#3 deferred ~10 days; closed by
    01:32:28Z env-spec landing.

    P12 — Alex-Pending Escalations Not Self-Liftable: caps the
    self-lift precedent supervisor invoked at 00:04:33Z. Rule: no
    agent may self-lift an Alex-pending hold; alternative paths
    execute on their own merits without 'hold-lift' framing.
    Origin: pythia python#145 python#1 + python#147 python#2 + python#148 python#2.

No code changes. Reference-only push.
SonicField added a commit to SonicField/cpython that referenced this pull request Apr 26, 2026
docs: cinderx-oracle env-spec v2 (post oracle-complete)
233fd67 
Push 62 (doc-only) — env-spec updated with lessons from 02:33Z dry-run
+ 02:39Z successful oracle execution that produced Phoenix-vs-Cinder
verdict (Phoenix faster on 3/3 benches, sub-1.0x inherited from Cinder).

Updates per theologian 02:41:37Z:
- Phoenix JIT activation: import _cinderx FIRST, then import cinderjit
  (corrects v1 assumption that cinderjit was directly importable)
- cinderx_dev JIT activation: from cinderx import jit; jit.force_compile
- Binary paths: ~/local/cinderx_dev/python-3.12/python (corrects v1
  assumption of ~/local/cinderx_dev/cinderx/python)
- LD_LIBRARY_PATH + PYTHONPATH env requirements for cinderx_dev
- Same-arch comparison (both ARM64 on devgpu004) verified working
- Application result section: oracle verdict + per-bench numbers
- Failure modes from 01:16Z (-X jit didn't activate) + 02:33Z (API
  enumeration gap) + both resolved methodologies

Closes pythia python#148 python#4 (spec-from-single-failure shipping before
empirical validation). v2 ships AFTER successful oracle execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran tiran approved these changes
Mariatta Mariatta approved these changes
orsenthil orsenthil left review comments
birkenfeld Awaiting requested review from birkenfeld
+1 more reviewer
Carreau Carreau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir sprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL