gh-142518: add thread safety annotations for tuple C-API - #148012
Merged
kumaraditya303 merged 6 commits intoApr 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ZeroIntensity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Isn't PyTuple_SetItem thread-safe on an "existing" tuple if the tuple is uniquely referenced?
Sorry, something went wrong.
Comment thread
Doc/c-api/tuple.rst
Outdated
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Copy link
Copy Markdown
Contributor
Author
Yes, that's what the docs mean by "This function should only be used to fill in brand new tuples" as brand new tuples are uniquely referenced. |
Sorry, something went wrong.
vstinner
approved these changes
Apr 7, 2026
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--148012.org.readthedocs.build/