GH-139922: add interpreter types to InternalDocs/interpreter.md - #148035
Merged
Fidget-Spinner merged 4 commits intoApr 5, 2026
Merged
GH-139922: add interpreter types to InternalDocs/interpreter.md#148035Fidget-Spinner merged 4 commits into
Fidget-Spinner merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
and explain some musttail peculiarities
chris-eibl
requested review from
Fidget-Spinner
and removed request for
AA-Turner
April 3, 2026 13:39
Comment thread
InternalDocs/interpreter.md
Outdated
Comment on lines
+536
to
+539
| also on the optimization level. [Introducing additional scopes](https://github.com/python/cpython/blob/3908593039bde9d4b591ab09919003ee57418d64/Python/bytecodes.c#L2526), | ||
| [extracting problematic code paths into a separate function](https://github.com/python/cpython/pull/143068/files#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342R3724) | ||
| or [returning a pointer instead of taking it as an output parameter](https://github.com/python/cpython/blob/3908593039bde9d4b591ab09919003ee57418d64/Include/internal/pycore_ceval.h#L489-L492) | ||
| is particularly helpful to the MSVC compiler in this regard. Using `restrict` is another (currently unused) remedy. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It would be better to place this as a bullet list:
The following remedies work: ...
Sorry, something went wrong.
chris-eibl
commented
Apr 3, 2026
Comment thread
InternalDocs/interpreter.md
| [preserve_none](https://clang.llvm.org/docs/AttributeReference.html#preserve-none) | ||
| calling convention between the small C functions that implement individual Python opcodes. | ||
|
|
||
| Not all compilers support these and if they do not all targets might be supported (for example, |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
See #148036 for a (current) list of supported MSVC configurations.
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And explain some musttail peculiarities.