gh-148059: Refactor codegen_deferred_annotations_body to avoid missing decref of mangled - #148060
Open
A0su wants to merge 4 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…oAvoidMissingDECREF
iritkatriel
approved these changes
Apr 5, 2026
Copy link
Copy Markdown
Member
|
It would be nice to add a test that fails on this (on the ref leaks build), if this is possible. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Thanks for the review, agreed on the test. I'll take a look over the next couple of days on adding something |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given this is a refactor and does not intend on changing functionality I didn't include tests. If some form of test is preferred, let me know. I'd be more than happy to include something.