FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and combine checks by kumaraditya303 · Pull Request #148070 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and combine checks - #148070

Merged
Fidget-Spinner merged 3 commits into
python:mainfrom
kumaraditya303:recursion
Apr 4, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and combine checks#148070
Fidget-Spinner merged 3 commits into
python:mainfrom
kumaraditya303:recursion

Conversation

kumaraditya303 commented Apr 4, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Apr 4, 2026
Open
Fidget-Spinner changed the title gh-131798: split recursion check to _CHECK_RECURSION_LIMIT gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and comine checks Apr 4, 2026
kumaraditya303 changed the title gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and comine checks gh-131798: split recursion check to _CHECK_RECURSION_LIMIT and combine checks Apr 4, 2026
Fidget-Spinner approved these changes Apr 4, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The key idea here is to combine recursion stack space limit checks into the first one. This is safe to do per-frame as subsequent calls should always return the frame to the same state according to how calls in C work.

Note that this is NOT the py recursion limit, which will require executor invalidation during sys setrecursionlimit to handle.

Comment thread Include/internal/pycore_optimizer_types.h Outdated
Fidget-Spinner merged commit e7bf8ea into python:main Apr 4, 2026
114 of 117 checks passed
kumaraditya303 deleted the recursion branch April 4, 2026 09:23
pablogsal mentioned this pull request Apr 4, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-131798: split recursion check to _CHECK_RECURSION_LIMIT and …
cf8c02b 
…combine checks (pythonGH-148070)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
savannahostrowski Awaiting requested review from savannahostrowski

Assignees

No one assigned

Labels

skip news topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL