Repository navigation
gh-148083: Prevent constant folding when lhs is container types - #148090
Merged
corona10 merged 2 commits intoApr 4, 2026
Merged
corona10 merged 2 commits into
corona10 merged 2 commits into
Conversation
corona10
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
April 4, 2026 13:17
Comment thread
Python/optimizer_symbols.c
Outdated
| } | ||
|
|
||
| bool | ||
| _Py_uop_sym_is_container(JitOptRef sym) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It's better to make this an allowlist, so we should say sym_is_not_container and check for the usual int float str etc
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Otherwise custom containers might be let through
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Done :)
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Apr 4, 2026
Fidget-Spinner
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.