FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-142927: Add scrollbar support to Tachyon HTML dark mode by Wulian233 · Pull Request #148118 · python/cpython · GitHub

/ cpython Public

gh-142927: Add scrollbar support to Tachyon HTML dark mode - #148118

Open
Wulian233 wants to merge 4 commits into
python:mainfrom
Wulian233:scrollbar
Open

gh-142927: Add scrollbar support to Tachyon HTML dark mode#148118
Wulian233 wants to merge 4 commits into
python:mainfrom
Wulian233:scrollbar

Conversation

Wulian233 commented Apr 5, 2026
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@hugovk

For compatibility, both approaches must be retained here.

::-webkit-scrollbar offers the widest compatibility, but requires fully customizing the scrollbar.
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Selectors/::-webkit-scrollbar#browser_compatibility


scrollbar-color is the newer standard, allowing us to style scrollbars without full customization. However, it is not supported by browsers from several years ago.

https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/scrollbar-color#browser_compatibility

Wulian233 requested a review from pablogsal as a code owner April 5, 2026 02:42
bedevere-app Bot mentioned this pull request Apr 5, 2026
11 tasks

hugovk commented Apr 5, 2026

Copy link
Copy Markdown
Member

These also apply to light mode, should they? And also * applies to every element.

But more importantly, this may override the user's OS scrollbar settings, which they may have customised for accessibility. Forcing them smaller and darker might mean it's hard for some to control or see.

Wulian233 commented Apr 5, 2026
edited
Loading

Copy link
Copy Markdown
Contributor Author

I adjusted the scope and now only add it where needed

But more importantly, this may override the user's OS scrollbar settings, which they may have customised for accessibility. Forcing them smaller and darker might mean it's hard for some to control or see.

This has been reused according to the existing heatmap design standards, so they should not have much impact:)

/* Scrollbar Styling */
.line-content::-webkit-scrollbar {
height: 6px;
}
.line-content::-webkit-scrollbar-thumb {
background: var(--border);
border-radius: 3px;
}
.line-content::-webkit-scrollbar-thumb:hover {
background: var(--text-muted);
}

Copy link
Copy Markdown
Contributor Author

@hugovk @pablogsal May I ask if there are any further changes I need?

Copy link
Copy Markdown
Member

@hugovk I am good with this PR but I will give you a couple of days before merging in case you have further comments.

hugovk commented Apr 10, 2026

Copy link
Copy Markdown
Member

I don't think we should change the scrollbars, it makes the colour contrast worse and can be harder to use for those who need it.

I don't think the original grey looks bad either.

Copy link
Copy Markdown
Contributor Author

Alright, I’ll choose to keep only the scrollbar-color, which avoids fully custom styling

When the browser supports this feature, it actually prefers the least intrusive approach

This image shows the case where scrollbar-color is not supported and ::-webkit-scrollbar is removed. I think in this situation, some users might perceive it as a design bug. It’s also inconsistent with the existing .line-content::-webkit-scrollbar. The flamegraph doesn’t support dark mode, but the heatmap does

pablogsal requested a review from hugovk April 25, 2026 21:37

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Testing on macOS, with Chrome 143, there's no difference. The scrollbars are already invisible: black on black with no outline. This PR doesn't change this.

Likewise on Safari 263, the scrollbars are black on black, but at least with a dark grey outline, so they're just about visible. This PR doesn't change this either.

On Firefox 149, this PR changes the scrollbars from light grey on black, to a darker grey on black. Both of these are better than Chrome and Safari, but I think it was better before.

If anything, we should be making the scrollbars [more] visible, not less.

}

/* Scrollbar Styling */
.line-content {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: we already have a .line-content block just before this.

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL