Repository navigation
gh-130472: Remove readline-only hacks from PyREPL completions - #148161
pablogsal merged 1 commit into
Conversation
Sorry, something went wrong.
PyREPL was still carrying over two readline-specific tricks from the fancy completer: a synthetic CSI prefix to influence sorting and a fake blank completion entry to suppress readline's prefix insertion. Those workarounds are not appropriate in PyREPL because the reader already owns completion ordering and menu rendering, so the fake entries leaked into the UI as real terminal attributes and empty menu cells. Sort completion candidates in ReadlineAlikeReader by their visible text with stripcolor(), and let the fancy completer return only real matches. That keeps colored completions stable without emitting bogus escape sequences, removes the empty completion slot, and adds regression tests for both the low-level completer output and the reader integration.
|
It fixes my issues, 
is it possible to have deeper alphabetic sorting, above all of the Py_ are jumbled together? |
Sorry, something went wrong.
|
Also good now: 
Looks like it's case-sensitive alphabetical, do you mean case-insensitive? |
Sorry, something went wrong.
I mean case-sensitive alphabetical, but to not stop at the second character, _. |
Sorry, something went wrong.
Let me see what I can do |
Sorry, something went wrong.
|
Check the latest commit. If you mean something different you are going to need to explain in more detail what you have in mind :) |
Sorry, something went wrong.
StanFromIreland
left a comment
There was a problem hiding this comment.
Oh sorry, you can revert the last commit, the current is better. I reviewed a7f83bd, LGTM
Sorry, something went wrong.
…ython#148161) PyREPL was still carrying over two readline-specific tricks from the fancy completer: a synthetic CSI prefix to influence sorting and a fake blank completion entry to suppress readline's prefix insertion. Those workarounds are not appropriate in PyREPL because the reader already owns completion ordering and menu rendering, so the fake entries leaked into the UI as real terminal attributes and empty menu cells. Sort completion candidates in ReadlineAlikeReader by their visible text with stripcolor(), and let the fancy completer return only real matches. That keeps colored completions stable without emitting bogus escape sequences, removes the empty completion slot, and adds regression tests for both the low-level completer output and the reader integration.
PyREPL was still carrying over two readline-specific tricks from the
fancy completer: a synthetic CSI prefix to influence sorting and a fake
blank completion entry to suppress readline's prefix insertion. Those
workarounds are not appropriate in PyREPL because the reader already
owns completion ordering and menu rendering, so the fake entries leaked
into the UI as real terminal attributes and empty menu cells.
Sort completion candidates in ReadlineAlikeReader by their visible text
with stripcolor(), and let the fancy completer return only real matches.
That keeps colored completions stable without emitting bogus escape
sequences, removes the empty completion slot, and adds regression tests
for both the low-level completer output and the reader integration.