Repository navigation
gh-148286: Fail on new UB in CI - #148168
Merged
StanFromIreland merged 11 commits intoApr 9, 2026
Merged
StanFromIreland merged 11 commits into
StanFromIreland merged 11 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I've never been so happy to see the CI fail :-) [3](https://github.com/python/cpython/actions/runs/24037637122/job/70101135069?pr=148168#step:11:144) ==> /home/runner/work/cpython/cpython/san_log.26255 <== Modules/binascii.c:1243:42: runtime error: left shift of 129 by 24 places cannot be represented in type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior Modules/binascii.c:1243:42 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
We got there in the end: #111758 (comment) :) I'd assumed that #135578 or #136820 included that but I didn't check. |
Sorry, something went wrong.
thesamesam
reviewed
Apr 6, 2026
Comment thread
.github/workflows/reusable-san.yml
thesamesam
reviewed
Apr 6, 2026
Comment thread
.github/workflows/reusable-san.yml
StanFromIreland
marked this pull request as ready for review
April 6, 2026 16:16
StanFromIreland
requested review from
AA-Turner,
ezio-melotti,
hugovk and
webknjaz
as code owners
April 6, 2026 16:16
StanFromIreland
marked this pull request as draft
April 6, 2026 16:19
StanFromIreland
marked this pull request as ready for review
April 6, 2026 17:19
Copy link
Copy Markdown
Member
|
LGTM, thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the reviews! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to debug a bit, it should be detecting #148166 (and also screaming about it), but it isn't. Mirroring what we do for the TSan job.
Just chucked everything in suppressions for now, they should be reviewed as it may have actual bugs.