Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

I have not added a news entry because this seems to me an extremely trivial change, however let me know if this could be required. Thank you very much.

For this, I think we should rather change upstream. I think we changed those values upstream instead (I don't want to diverge from HACL* sources in general).

cc @protz

Thanks I'll replicate the patch upstream

@carlo-bramini Could you update the PR so that it pulls the updated upstream instead (update refresh.sh to pull new sources)

Sorry, I meant you need to change the refresh.sh script in Modules/_hacl (or something like that) and set the commit hash that contains the upstream fix.

All commit authors signed the Contributor License Agreement.

The following commit authors need to sign the Contributor License Agreement:

* [30959007+carlo-bramini@users.noreply.github.com](mailto:30959007+carlo-bramini@users.noreply.github.com)

Excuse me, I had already signed the CLA, what is this?

Excuse me, I had already signed the CLA, what is this?

This may happen if you push with a different account / git setting or sometimes web UI

FTR, you need to call the refresh.sh script (it seems the upstream commit was not pulled)

Oh and you actually need a local HACL* copy for that to work.

@picnixz @protz I have seen that there are several copies of Lib_Memzero0.c into the upstream of HACL.
The patch has been imported only into lib/c/Lib_Memzero0.c, but the refresh.sh script from the sources of Python is importing a file with the same name but from the dist\gcc-compatible directory.
As result, the latest patches are not imported into Python.
How does this thing need to be handled?

Upstream was just fixed via hacl-star/hacl-star#1070 which propagates the hand-written copy into the packaged distributions ("dist").

Sorry for the confusion -- I should've commented here that there were still a few more steps required to fully propagate the fix.

@protz:

Upstream was just fixed via hacl-star/hacl-star#1070 which propagates the hand-written copy into the packaged distributions ("dist").

I created PR gh-149802 to Modules/_hacl/ for Cygwin.

I merged #149802 instead. Thanks for your contribution!