FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-148235: remove duplicate uops `_LOAD_CONST_UNDER_INLINE(_BORROW)` in JIT by NekoAsakura · Pull Request #148236 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-148235: remove duplicate uops _LOAD_CONST_UNDER_INLINE(_BORROW) in JIT - #148236

Merged
Fidget-Spinner merged 3 commits into
python:mainfrom
NekoAsakura:gh-148235/dedup-uop
Apr 8, 2026
ConversationCommits (3)ChecksFiles changed
Merged

gh-148235: remove duplicate uops _LOAD_CONST_UNDER_INLINE(_BORROW) in JIT#148236
Fidget-Spinner merged 3 commits into
python:mainfrom
NekoAsakura:gh-148235/dedup-uop

Conversation

NekoAsakura commented Apr 8, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 8, 2026
Closed

Fidget-Spinner commented Apr 8, 2026

Copy link
Copy Markdown
Member

Sorry but I'd rather remove LOAD_CONST_UNDER_INLINE_X as the INSERT_X is clearer. Also the tests changes need fixing, thanks!

In the longer-term we should change INSERT_X... to LOAD_CONST_INLINE, SWAP X

NekoAsakura changed the title gh-148235: remove duplicate uops _INSERT_1_LOAD_CONST_INLINE(_BORROW) in JIT gh-148235: remove duplicate uops _LOAD_CONST_UNDER_INLINE(_BORROW) in JIT Apr 8, 2026

NekoAsakura commented Apr 8, 2026

Copy link
Copy Markdown
Member Author

Done :)

Fidget-Spinner reviewed Apr 8, 2026
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py
uops = get_opnames(ex)
self.assertNotIn("_UNARY_INVERT", uops)
self.assertIn("_INSERT_1_LOAD_CONST_INLINE_BORROW", uops)
self.assertIn("_LOAD_CONST_INLINE_BORROW", uops)

Fidget-Spinner Apr 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why this change?

NekoAsakura Apr 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

_INSERT_1_LOAD_CONST_INLINE_BORROW has no op_without_push entry on main, therefore not simplified away by remove_unneeded_uops.

Comment thread Python/bytecodes.c Outdated
Comment thread Lib/test/test_capi/test_opt.py
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertNotIn("_REPLACE_WITH_TRUE", uops)
self.assertIn("_INSERT_1_LOAD_CONST_INLINE_BORROW", uops)

Fidget-Spinner Apr 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why this change?

NekoAsakura Apr 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same reason.

Fidget-Spinner approved these changes Apr 8, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

Fidget-Spinner merged commit 7563585 into python:main Apr 8, 2026
78 checks passed
NekoAsakura deleted the gh-148235/dedup-uop branch April 8, 2026 12:10
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-148235: remove duplicate uops `_LOAD_CONST_UNDER_INLINE(_BOR…
ebb1a4d 
…ROW)` in JIT (pythonGH-148236)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
savannahostrowski Awaiting requested review from savannahostrowski

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL