gh-123471: Make concurrent iteration over itertools.islice thread-safe using a critical section - #148348
Open
eendebakpt wants to merge 3 commits into
Open
gh-123471: Make concurrent iteration over itertools.islice thread-safe using a critical section#148348eendebakpt wants to merge 3 commits into
eendebakpt wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I could not reproduce the new test against main. I reproduced an assertion failure after changing the numbers. @threading_helper.reap_threads
def test_islice(self):
number_of_iterations = 600
for _ in range(number_of_iterations):
it = islice(tuple(range(100000)), 1, 8000000, 2)
threading_helper.run_concurrently(work_iterator, nthreads=10, args=[it])Which resulted in: Python/gc_free_threading.c:1083: validate_refcounts: Assertion "_Py_REFCNT(((PyObject*)((op)))) > 0" failed: tracked objects must have a reference count > 0 I didn't check how long it takes to run this test, but we would ideally keep it short. Can you find a way to make it reliably fail on main? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we use a critical section. An alternative approach is to use atomics (#144528), but that is more complex.