FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-148211: decompose `_POP_TWO/_POP_CALL(_ONE/_TWO)` in JIT by NekoAsakura · Pull Request #148377 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-148211: decompose _POP_TWO/_POP_CALL(_ONE/_TWO) in JIT - #148377

Merged
Fidget-Spinner merged 2 commits into
python:mainfrom
NekoAsakura:gh-148211/decompose-pop-call-pop-two
Apr 11, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-148211: decompose _POP_TWO/_POP_CALL(_ONE/_TWO) in JIT#148377
Fidget-Spinner merged 2 commits into
python:mainfrom
NekoAsakura:gh-148211/decompose-pop-call-pop-two

Conversation

NekoAsakura commented Apr 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 11, 2026
Closed
Fidget-Spinner approved these changes Apr 11, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great work! I can finally close the issue. The JIT is in a much cleaner state now.

Fidget-Spinner merged commit 9831dea into python:main Apr 11, 2026
91 checks passed
NekoAsakura deleted the gh-148211/decompose-pop-call-pop-two branch April 11, 2026 12:59

bedevere-bot commented Apr 11, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.x (tier-3) has failed when building commit 9831dea.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1613/builds/3119) and take a look at the build logs.
  4. Check if the failure is related to this commit (9831dea) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1613/builds/3119

Failed tests:

  • test_datetime

Test leaking resources:

  • test_events: memory blocks
  • test_events: references

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 948, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 15773), raddr=('127.0.0.1', 15774)>
Task was destroyed but it is pending!
task: <Task pending name='Task-3855' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:219> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x843567d10>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 877, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 948, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('127.0.0.1', 30709), raddr=('127.0.0.1', 30710)>
Task was destroyed but it is pending!
task: <Task pending name='Task-320' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:219> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x844059190>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 877, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=8>
k

Fidget-Spinner commented Apr 11, 2026

Copy link
Copy Markdown
Member

Probably not this PR but one of the other POP_TOP refactoring ones.

NekoAsakura commented Apr 11, 2026

Copy link
Copy Markdown
Member Author

False positive? Is it safe to ignore?

Fidget-Spinner commented Apr 11, 2026

Copy link
Copy Markdown
Member

Yeah I checked the logs, should be safe to ignore.

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-148211: decompose _POP_TWO/_POP_CALL(_ONE/_TWO) in JIT (py…
e2c9b33 
…thonGH-148377)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
savannahostrowski Awaiting requested review from savannahostrowski

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL