gh-137855: Improve import time of dataclasses by lazy importing re and copy modules - #148379
Merged
hugovk merged 7 commits intoApr 11, 2026
Merged
gh-137855: Improve import time of dataclasses by lazy importing re and copy modules#148379hugovk merged 7 commits into
hugovk merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
hugovk
reviewed
Apr 11, 2026
Comment thread
Lib/dataclasses.py
Outdated
Comment thread
Lib/dataclasses.py
Outdated
Comment thread
Lib/dataclasses.py
Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
Author
|
The failing Ubuntu build is a transient issue during dependency installation that will hopefully go away when the job is restarted. |
Sorry, something went wrong.
hugovk
approved these changes
Apr 11, 2026
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
hugovk
enabled auto-merge (squash)
April 11, 2026 20:47
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
… `re` and `copy` modules (python#148379) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #144387 as requested by @hugovk (tagging for review :-) This is a relatively minor win, the bigger win will come from lazy importing inspect in #144387
See below for tuna-visualized outputs from ./python -X importtime -c "import dataclasses"
(the absolute import numbers are not representative as I was running a debug python build)
Before
After