FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131798: do not watch immutable types in JIT by kumaraditya303 · Pull Request #148383 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131798: do not watch immutable types in JIT - #148383

Merged
kumaraditya303 merged 4 commits into
python:mainfrom
kumaraditya303:jit-bloom
Apr 11, 2026
ConversationCommits (4)ChecksFiles changed
Merged

gh-131798: do not watch immutable types in JIT#148383
kumaraditya303 merged 4 commits into
python:mainfrom
kumaraditya303:jit-bloom

Conversation

kumaraditya303 commented Apr 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Immutable types cannot change so there is no need to add type watcher to them and add it to bloom filter. This reduces the false positive from bloom filters.

bedevere-app Bot mentioned this pull request Apr 11, 2026
Open
kumaraditya303 commented Apr 11, 2026
View reviewed changes
Comment thread Python/optimizer_analysis.c

Fidget-Spinner commented Apr 11, 2026

Copy link
Copy Markdown
Member

I just merged a PR that watches more types 1c89817 I assume those don't need to be checked, as immutable types usually have no __init__ and STORE_ATTR_INSTANCE_VALUE? Though I may be wrong.

Also can you edit your PR description to explain why (e.g. reduce the chance of false positive in bloom filter).

kumaraditya303 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor Author

I assume those don't need to be checked, as immutable types usually have no init and STORE_ATTR_INSTANCE_VALUE? Though I may be wrong.

Immutable types does not mean that the object is immutable too, like dict so it can have __init__.

Also can you edit your PR description to explain why (e.g. reduce the chance of false positive in bloom filter).

Edited.

Fidget-Spinner commented Apr 11, 2026

Copy link
Copy Markdown
Member

Oh ok. In that case, please pull in main and do the same then. Thanks!

Fidget-Spinner approved these changes Apr 11, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

kumaraditya303 enabled auto-merge (squash) April 11, 2026 15:18
kumaraditya303 merged commit ba1e1c1 into python:main Apr 11, 2026
73 checks passed
kumaraditya303 deleted the jit-bloom branch April 11, 2026 15:57
Fidget-Spinner mentioned this pull request Apr 12, 2026
Merged
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-131798: do not watch immutable types in JIT (python#148383)
9ecd501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
Fidget-Spinner Fidget-Spinner approved these changes
cocolato cocolato approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
savannahostrowski Awaiting requested review from savannahostrowski

Assignees

No one assigned

Labels

skip news topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL