FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-148438: implement `_RECORD_BOUND_METHOD` in JIT by NekoAsakura · Pull Request #148457 · python/cpython · GitHub

/ cpython Public

gh-148438: implement _RECORD_BOUND_METHOD in JIT - #148457

Merged
Fidget-Spinner merged 7 commits into
python:mainfrom
NekoAsakura:gh-148438/record-bound-method
Apr 12, 2026
ConversationCommits (7)ChecksFiles changed
Merged

gh-148438: implement _RECORD_BOUND_METHOD in JIT#148457
Fidget-Spinner merged 7 commits into
python:mainfrom
NekoAsakura:gh-148438/record-bound-method

Conversation

NekoAsakura commented Apr 12, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

_RECORD_BOUND_METHOD records method object now, so _EXACT_ARGS needs to extract im_func out of it as well.

bedevere-app Bot mentioned this pull request Apr 12, 2026
Closed

NekoAsakura commented Apr 12, 2026

Copy link
Copy Markdown
Member Author

Uh, didn't realise ADD_OP replaces the current instruction rather than adds after it. Should be sorted now.

cpython/Python/optimizer_analysis.c

Lines 623 to 627 in 03d2f03

// If no ADD_OP was called during this iteration, copy the original instruction
if (ctx->out_buffer.next == out_ptr) {
*(ctx->out_buffer.next++) = *this_instr;
}
assert(ctx->frame != NULL);

Fidget-Spinner reviewed Apr 12, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very close, thanks. Some tricky bits that I explain below.

Comment thread Python/optimizer_bytecodes.c
Comment thread Python/optimizer_bytecodes.c Outdated

Fidget-Spinner Apr 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We can one-up this. If it's a probable constant callable, and the func_version matches, we can promote the callable to a known one, just like you did in_CHECK_METHOD_VERSION .

Also, heads up I'm merging my PR https://github.com/python/cpython/pull/146300/changes because _CHECK_FUNCTION_VERSION is wrong for the first if case.

Fidget-Spinner Apr 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops sorry, my other PR's change does the same thing now to fix this. Sorry, please undo the change here and then I'll land my PR!

NekoAsakura Apr 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Roger :)

Comment thread Python/optimizer_bytecodes.c
Comment thread Python/optimizer_bytecodes.c

NekoAsakura commented Apr 12, 2026

Copy link
Copy Markdown
Member Author

Done. Will sort conflicts once #146300 is in. Really appreciate the review, cheers

Fidget-Spinner approved these changes Apr 12, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

Fidget-Spinner merged commit 6349262 into python:main Apr 12, 2026
78 checks passed
NekoAsakura deleted the gh-148438/record-bound-method branch April 12, 2026 19:03
prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request Apr 13, 2026
Revert "pythongh-148438: implement _RECORD_BOUND_METHOD in JIT (pyt…
ddbedbb 
…honGH-148457)"

This reverts commit 6349262.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-148438: implement _RECORD_BOUND_METHOD in JIT (pythonGH-14…
fb991d4 
…8457)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL