Repository navigation
gh-131798: optimize through keyword and bound method calls in the JIT - #148466
Merged
Fidget-Spinner merged 7 commits intoApr 13, 2026
Merged
Fidget-Spinner merged 7 commits into
Fidget-Spinner merged 7 commits into
Conversation
kumaraditya303
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
April 12, 2026 19:09
Comment thread
Python/optimizer_bytecodes.c
Comment thread
Lib/test/test_capi/test_opt.py
Outdated
|
|
||
| def test_call_kw(self): | ||
| def func(a): | ||
| return 42 * a |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We should be checking that we optimize through the trace. So the best way is to put a global (e.g. range) here and check if it gets promoted in the tests below. See for example test_init_resolves_callable which does self.assertNotIn("_LOAD_GLOBAL_BUILTINS", uops). Same for the other test.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It's not optimizing through the bound method because we're missing _EXPAND_METHOD_KW in the JIT. I think you can just copy whatever _EXPAND_METHOD has and place it under there. |
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Apr 13, 2026
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks! This should be a pretty decent win.
Sorry, something went wrong.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…he JIT (pythonGH-148466) Co-authored-by: Ken Jin <kenjin4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.