FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-121946: Use clang-20 for TSan build by colesbury · Pull Request #148570 · python/cpython · GitHub

/ cpython Public

gh-121946: Use clang-20 for TSan build - #148570

Merged
hugovk merged 1 commit into
python:mainfrom
colesbury:gh-121946-san-clang-20
Apr 19, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-121946: Use clang-20 for TSan build#148570
hugovk merged 1 commit into
python:mainfrom
colesbury:gh-121946-san-clang-20

Conversation

colesbury commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Almost 2 years ago, we switched to clang-17 because of broken apt packaging. That's been fixed for a while now. I think we can use clang-20 for all our sanitizer tests.

bedevere-app Bot mentioned this pull request Apr 14, 2026
Closed
sharktide reviewed Apr 14, 2026
View reviewed changes

sharktide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I know it’s still a draft, but it looks good to me

colesbury marked this pull request as ready for review April 17, 2026 19:25
webknjaz added 3.11 only security fixes 3.10 only security fixes 3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 pre-release feature fixes, bugs and security fixes labels Apr 17, 2026
webknjaz approved these changes Apr 17, 2026
View reviewed changes

webknjaz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks reasonable. Let's make sure to backport the patch for the sake of maintenance.

hugovk merged commit ad7d361 into python:main Apr 19, 2026
64 checks passed
hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed 3.11 only security fixes 3.10 only security fixes 3.12 only security fixes 3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 pre-release feature fixes, bugs and security fixes labels Apr 19, 2026

miss-islington-app Bot commented Apr 19, 2026

Copy link
Copy Markdown

Thanks @colesbury for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Apr 19, 2026

Copy link
Copy Markdown

Thanks @colesbury for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 19, 2026
pythongh-121946: Use clang-20 for TSan build (pythonGH-148570)
356365e 
(cherry picked from commit ad7d361)

Co-authored-by: Sam Gross <colesbury@gmail.com>

bedevere-app Bot commented Apr 19, 2026

Copy link
Copy Markdown

GH-148754 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 19, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 19, 2026
pythongh-121946: Use clang-20 for TSan build (pythonGH-148570)
0fb4e03 
(cherry picked from commit ad7d361)

Co-authored-by: Sam Gross <colesbury@gmail.com>

bedevere-app Bot commented Apr 19, 2026

Copy link
Copy Markdown

GH-148755 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Apr 19, 2026
hugovk pushed a commit that referenced this pull request Apr 19, 2026
[3.14] gh-121946: Use clang-20 for TSan build (GH-148570) (#148755)
e9aacf9 
Co-authored-by: Sam Gross <colesbury@gmail.com>
hugovk pushed a commit that referenced this pull request Apr 19, 2026
[3.13] gh-121946: Use clang-20 for TSan build (GH-148570) (#148754)
00a9a8a 
Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury deleted the gh-121946-san-clang-20 branch April 20, 2026 15:20
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-121946: Use clang-20 for TSan build (python#148570)
9b45855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

webknjaz webknjaz approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
+1 more reviewer
sharktide sharktide left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL