Repository navigation
gh-137335: remove a mktemp use in multiprocessing.connection to avoid security scanner noise - #148578
gpshead merged 1 commit into
Conversation
Sorry, something went wrong.
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
… avoid security scanner noise (pythonGH-148578) remove a mktemp use to avoid security scanner noise (cherry picked from commit fd81246) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
… avoid security scanner noise (pythonGH-148578) remove a mktemp use to avoid security scanner noise (cherry picked from commit fd81246) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
|
GH-148583 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
|
GH-148584 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
…o avoid security scanner noise (GH-148578) (#148583) gh-137335: remove a mktemp use in multiprocessing.connection to avoid security scanner noise (GH-148578) remove a mktemp use to avoid security scanner noise (cherry picked from commit fd81246) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
…o avoid security scanner noise (GH-148578) (#148584) gh-137335: remove a mktemp use in multiprocessing.connection to avoid security scanner noise (GH-148578) remove a mktemp use to avoid security scanner noise (cherry picked from commit fd81246) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
… avoid security scanner noise (pythonGH-148578) remove a mktemp use to avoid security scanner noise
|
I think it is better to revert this change. The use of tempfile.mktemp() was correct, the code was clear. Now we have a tiny chance of error, to fix it we need to reimplement the logic of tempfile.mktemp() in the multiprocessing code. See also #149527. This is also an argument in favor of not deprecating tempfile.mktemp(). But we can deprecate it's use with the default dir which is not secure. |
Sorry, something went wrong.
This is not a security issue given it is a random filename in a mode 0o700 mkdtemp directory, but naive automated scanners that don't do code analysis flag it regardless. (https://github.com/python/cpython/security/code-scanning/190)
Followon to #137389 which fixed a bunch of others.