FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-148758: Fix dynamic loading file extensions for CYGWIN by carlo-bramini · Pull Request #148759 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-148758: Fix dynamic loading file extensions for CYGWIN - #148759

Merged
vstinner merged 2 commits into
python:mainfrom
carlo-bramini:fix-cygwin-error-2
May 13, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-148758: Fix dynamic loading file extensions for CYGWIN#148759
vstinner merged 2 commits into
python:mainfrom
carlo-bramini:fix-cygwin-error-2

Conversation

carlo-bramini commented Apr 19, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This patch fixes issue #148758.

After applying the patch, this will be the result on the console:

Checked 115 modules (37 built-in, 77 shared, 1 n/a on cygwin-3.6.7-x86_64, 0 disabled, 0 missing, 0 failed on import)

pythongh-148758: Fix dynamic loading file extensions for CYGWIN
132dc4a 
This patch fixes issue python#148758.

After applying the patch, this will be the result on the console:

Checked 115 modules (37 built-in, 77 shared, 1 n/a on cygwin-3.6.7-x86_64, 0 disabled, 0 missing, 0 failed on import)

bedevere-app Bot commented Apr 19, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Apr 19, 2026
Closed

lazka commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

For what it's worth, lgtm.

We have been carrying this patch in MSYS2 for many years, and from what I see cygwin has too.

vstinner reviewed May 13, 2026
View reviewed changes
Comment thread Python/dynload_shlib.c Outdated

read-the-docs-community Bot commented May 13, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32680002 | 📁 Comparing 6ed7ed6 against main (b6854c5)

  🔍 Preview build  

128 files changed · ± 125 modified · - 3 deleted

± Modified

- Deleted

vstinner commented May 13, 2026

Copy link
Copy Markdown
Member

I'm not sure that the .abi3.dll suffix is properly supported, so I chose to remove it. It can be added later if someone can test/prove that the stable ABI works on Cygwin.

vstinner commented May 13, 2026

Copy link
Copy Markdown
Member

test_perf_profiler failed with a segfault on the macos-26 CI:

FAIL: test_trampoline_works_with_forks (test.test_perf_profiler.TestPerfTrampoline.test_trampoline_works_with_forks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/cpython/cpython/Lib/test/test_perf_profiler.py", line 145, in test_trampoline_works_with_forks
    self.assertEqual(process.returncode, 0)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 11 != 0

vstinner approved these changes May 13, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner enabled auto-merge (squash) May 13, 2026 21:50
vstinner merged commit 50476a7 into python:main May 13, 2026
100 of 102 checks passed

vstinner commented May 13, 2026

Copy link
Copy Markdown
Member

Ok, I merged your change. Thanks for the fix!

carlo-bramini deleted the fix-cygwin-error-2 branch May 14, 2026 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL