Repository navigation
gh-148211: decompose _SHUFFLE_3_LOAD_CONST_INLINE_BORROW in JIT - #148816
Merged
markshannon merged 3 commits intoApr 28, 2026
Merged
markshannon merged 3 commits into
markshannon merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
NekoAsakura
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
April 20, 2026 23:54
cocolato
approved these changes
Apr 21, 2026
Copy link
Copy Markdown
Member
|
LGTM, Thanks! |
Sorry, something went wrong.
markshannon
reviewed
Apr 28, 2026
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Note: It might be worth adding ROT_3 and a RROT_3 uops to use in the optimizer and the peepholer. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed one.