GH-146073: Add fitness to executor dumps. - #148959
Merged
markshannon merged 2 commits intoApr 27, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
markshannon
requested review from
Fidget-Spinner,
savannahostrowski and
tomasr8
as code owners
April 24, 2026 14:17
cocolato
reviewed
Apr 26, 2026
Comment thread
Python/optimizer.c
| inst->operand0 = operand; | ||
| #ifdef Py_STATS | ||
| inst->execution_count = 0; | ||
| inst->fitness = tracer->translator_state.fitness; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should we need reset/set fitness when calling make_exit?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
The fitness of an exit is meaningless. We could set it to zero, to avoid confusion
Sorry, something went wrong.
diegorusso
approved these changes
Apr 27, 2026
diegorusso
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the fitness to trace dumps, to make it easier to see when the fitness and actual execution counts diverge.
Example: