FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-148967: Fix FFI type pointer handling for C complex support in set_stginfo_ffi_type_pointer by sunmy2019 · Pull Request #148969 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-148967: Fix FFI type pointer handling for C complex support in set_stginfo_ffi_type_pointer - #148969

Merged
encukou merged 2 commits into
python:mainfrom
sunmy2019:gh-148967
May 1, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-148967: Fix FFI type pointer handling for C complex support in set_stginfo_ffi_type_pointer#148969
encukou merged 2 commits into
python:mainfrom
sunmy2019:gh-148967

Conversation

sunmy2019 commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

The else branch is taken from the earlier _ctype.c.

bedevere-app Bot mentioned this pull request Apr 24, 2026
Closed
sunmy2019 requested review from encukou and skirpichev April 24, 2026 17:55

sunmy2019 commented Apr 24, 2026

Copy link
Copy Markdown
Member Author

I don't think we need to add NEWs. The regression is just introduced by 769cc83.

sunmy2019 added 3.14 bugs and security fixes needs backport to 3.14 bugs and security fixes 3.15 bugs and security fixes skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 24, 2026

bedevere-bot commented Apr 24, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sunmy2019 for commit 6d85124 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F148969%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 24, 2026
sunmy2019 removed 3.14 bugs and security fixes 3.15 bugs and security fixes labels Apr 24, 2026
skirpichev approved these changes Apr 24, 2026
View reviewed changes

skirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the fix.

skirpichev reviewed Apr 25, 2026
View reviewed changes
Comment thread Modules/_ctypes/_ctypes.c
encukou merged commit f2c7c0d into python:main May 1, 2026
142 of 143 checks passed

miss-islington-app Bot commented May 1, 2026

Copy link
Copy Markdown

Thanks @sunmy2019 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

bedevere-app Bot commented May 1, 2026

Copy link
Copy Markdown

GH-149224 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 1, 2026
encukou pushed a commit that referenced this pull request May 1, 2026
[3.14] gh-148967: Fix FFI type pointer handling for C complex support…
5ec845a 
… in set_stginfo_ffi_type_pointer (GH-148969) (GH-149224)

(cherry picked from commit f2c7c0d)

Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skirpichev skirpichev approved these changes
encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL