FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-149171: Make TypeAliasType __module__ writable by ericmarkmartin · Pull Request #149172 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-149171: Make TypeAliasType __module__ writable #149172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
May 2, 2026
Conversation 6 Commits 1 Checks 56 Files changed
Merged

gh-149171: Make TypeAliasType __module__ writable #149172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .c  (1) .py  (1) .rst  (2) All 3 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
6 changes: 6 additions & 0 deletions Doc/library/typing.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2361,6 +2361,12 @@ without the dedicated syntax, as documented below.
>>> Alias.__module__
'__main__'

This attribute is writable.

.. versionchanged:: 3.15

The attribute is now writable.

.. attribute:: __type_params__

The type parameters of the type alias, or an empty tuple if the alias is
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test_type_aliases.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,8 @@ def test_module(self):
mod_generics_cache.__name__)
self.assertEqual(mod_generics_cache.OldStyle.__module__,
mod_generics_cache.__name__)
Alias.__module__ = "ham.spam.eggs"
self.assertEqual(Alias.__module__, "ham.spam.eggs")

def test_unpack(self):
type Alias = tuple[int, int]
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-04-30-01-35-09.gh-issue-149171.meXWpl.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Allow assignment to the ``__module__`` attribute of
:class:`typing.TypeAliasType` instances.
27 changes: 23 additions & 4 deletions Objects/typevarobject.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1983,8 +1983,12 @@ static PyObject *
typealias_module(PyObject *self, void *Py_UNUSED(closure))
{
typealiasobject *ta = typealiasobject_CAST(self);
if (ta->module != NULL) {
return Py_NewRef(ta->module);
PyObject *module;
Py_BEGIN_CRITICAL_SECTION(self);
module = Py_XNewRef(ta->module);
Py_END_CRITICAL_SECTION();
if (module != NULL) {
return module;
}
if (ta->compute_value != NULL) {
PyObject* mod = PyFunction_GetModule(ta->compute_value);
Expand All @@ -1998,12 +2002,25 @@ typealias_module(PyObject *self, void *Py_UNUSED(closure))
Py_RETURN_NONE;
}

static int
typealias_set_module(PyObject *self, PyObject *value, void *Py_UNUSED(closure))
{
PyObject *old;
typealiasobject *ta = typealiasobject_CAST(self);
Py_BEGIN_CRITICAL_SECTION(self);
old = ta->module;
ta->module = Py_XNewRef(value);
Py_END_CRITICAL_SECTION();
Py_XDECREF(old);
return 0;
}

static PyGetSetDef typealias_getset[] = {
{"__parameters__", typealias_parameters, NULL, NULL, NULL},
{"__type_params__", typealias_type_params, NULL, NULL, NULL},
{"__value__", typealias_value, NULL, NULL, NULL},
{"evaluate_value", typealias_evaluate_value, NULL, NULL, NULL},
{"__module__", typealias_module, NULL, NULL, NULL},
{"__module__", typealias_module, typealias_set_module, NULL, NULL},
{0}
};

Expand Down Expand Up @@ -2203,7 +2220,9 @@ type checkers.\n\
At runtime, Alias is an instance of TypeAliasType. The __name__\n\
attribute holds the name of the type alias. The value of the type alias\n\
is stored in the __value__ attribute. It is evaluated lazily, so the\n\
value is computed only if the attribute is accessed.\n\
value is computed only if the attribute is accessed. The __module__\n\
attribute holds the name of the module in which the type alias was\n\
defined; it can be assigned to.\n\
\n\
Type aliases can also be generic::\n\
\n\
Expand Down
Loading
Back | FazBrowse Home | New Git URL